2019-05-31 20:17:59

by Qian Cai

Subject: [PATCH -next] intel-iommu: fix a variable set but not used

The commit "iommu/vt-d: Delegate the dma domain to upper layer" left an
unused variable,

drivers/iommu/intel-iommu.c: In function 'disable_dmar_iommu':
drivers/iommu/intel-iommu.c:1652:23: warning: variable 'domain' set but
not used [-Wunused-but-set-variable]

Signed-off-by: Qian Cai <[email protected]>
---
drivers/iommu/intel-iommu.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index b431cc6f6ba4..073c547f247a 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -1649,16 +1649,12 @@ static void disable_dmar_iommu(struct intel_iommu *iommu)

spin_lock_irqsave(&device_domain_lock, flags);
list_for_each_entry_safe(info, tmp, &device_domain_list, global) {
- struct dmar_domain *domain;
-
if (info->iommu != iommu)
continue;

if (!info->dev || !info->domain)
continue;

- domain = info->domain;
-
__dmar_remove_one_dev_info(info);
}
spin_unlock_irqrestore(&device_domain_lock, flags);
--
1.8.3.1

2019-06-03 16:43:18

by Jörg Rödel

Subject: Re: [PATCH -next] intel-iommu: fix a variable set but not used

On Fri, May 31, 2019 at 04:16:02PM -0400, Qian Cai wrote:
> The commit "iommu/vt-d: Delegate the dma domain to upper layer" left an
> unused variable,
>
> drivers/iommu/intel-iommu.c: In function 'disable_dmar_iommu':
> drivers/iommu/intel-iommu.c:1652:23: warning: variable 'domain' set but
> not used [-Wunused-but-set-variable]
>
> Signed-off-by: Qian Cai <[email protected]>
> ---
> drivers/iommu/intel-iommu.c | 4 ----
> 1 file changed, 4 deletions(-)

Applied, thanks.