2019-06-04 08:14:28

by Nishka Dasgupta

Subject: [PATCH] staging: rtl8188eu: core: Replace function rtw_free_network_nolock

Remove function rtw_free_network_nolock, as all it does is call
_rtw_free_network_nolock, and rename _rtw_free_network_nolock to
rtw_free_network_nolock.

Signed-off-by: Nishka Dasgupta <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
index 0abb2df32645..454c5795903d 100644
--- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
@@ -159,7 +159,7 @@ static void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *
spin_unlock_bh(&free_queue->lock);
}

-void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwork)
+void rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwork)
{
struct __queue *free_queue = &pmlmepriv->free_bss_pool;

@@ -276,12 +276,6 @@ static struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv)
return _rtw_alloc_network(pmlmepriv);
}

-static void rtw_free_network_nolock(struct mlme_priv *pmlmepriv,
- struct wlan_network *pnetwork)
-{
- _rtw_free_network_nolock(pmlmepriv, pnetwork);
-}
-
int rtw_is_same_ibss(struct adapter *adapter, struct wlan_network *pnetwork)
{
int ret = true;
--
2.19.1

2019-06-06 13:06:27

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8188eu: core: Replace function rtw_free_network_nolock

On Tue, Jun 04, 2019 at 01:42:22PM +0530, Nishka Dasgupta wrote:
> Remove function rtw_free_network_nolock, as all it does is call
> _rtw_free_network_nolock, and rename _rtw_free_network_nolock to
> rtw_free_network_nolock.
>
> Signed-off-by: Nishka Dasgupta <[email protected]>
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> index 0abb2df32645..454c5795903d 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> @@ -159,7 +159,7 @@ static void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *
> spin_unlock_bh(&free_queue->lock);
> }
>
> -void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwork)
> +void rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwork)

Why is this function moved from being static to not being static?

that doesn't seem right to me, does it to you?

thanks,

greg k-h