2019-05-31 07:41:06

by Pi-Hsun Shih

[permalink] [raw]
Subject: [PATCH v9 5/7] dt-bindings: Add binding for cros-ec-rpmsg.

Add a DT binding documentation for ChromeOS EC driver over rpmsg.

Signed-off-by: Pi-Hsun Shih <[email protected]>
Acked-by: Rob Herring <[email protected]>

---
Changes from v8, v7, v6:
- No change.

Changes from v5:
- New patch.
---
Documentation/devicetree/bindings/mfd/cros-ec.txt | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
index 6245c9b1a68b..4860eabd0f72 100644
--- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
+++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
@@ -3,7 +3,7 @@ ChromeOS Embedded Controller
Google's ChromeOS EC is a Cortex-M device which talks to the AP and
implements various function such as keyboard and battery charging.

-The EC can be connect through various means (I2C, SPI, LPC) and the
+The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the
compatible string used depends on the interface. Each connection method has
its own driver which connects to the top level interface-agnostic EC driver.
Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to
@@ -17,6 +17,9 @@ Required properties (SPI):
- compatible: "google,cros-ec-spi"
- reg: SPI chip select

+Required properties (RPMSG):
+- compatible: "google,cros-ec-rpmsg"
+
Optional properties (SPI):
- google,cros-ec-spi-pre-delay: Some implementations of the EC need a little
time to wake up from sleep before they can receive SPI transfers at a high
--
2.22.0.rc1.257.g3120a18244-goog


2019-06-04 18:00:50

by Benson Leung

[permalink] [raw]
Subject: Re: [PATCH v9 5/7] dt-bindings: Add binding for cros-ec-rpmsg.

On Fri, May 31, 2019 at 03:38:46PM +0800, Pi-Hsun Shih wrote:
> Add a DT binding documentation for ChromeOS EC driver over rpmsg.
>
> Signed-off-by: Pi-Hsun Shih <[email protected]>
> Acked-by: Rob Herring <[email protected]>

Reviewed-by: Benson Leung <[email protected]>

>
> ---
> Changes from v8, v7, v6:
> - No change.
>
> Changes from v5:
> - New patch.
> ---
> Documentation/devicetree/bindings/mfd/cros-ec.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> index 6245c9b1a68b..4860eabd0f72 100644
> --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
> +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> @@ -3,7 +3,7 @@ ChromeOS Embedded Controller
> Google's ChromeOS EC is a Cortex-M device which talks to the AP and
> implements various function such as keyboard and battery charging.
>
> -The EC can be connect through various means (I2C, SPI, LPC) and the
> +The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the
> compatible string used depends on the interface. Each connection method has
> its own driver which connects to the top level interface-agnostic EC driver.
> Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to
> @@ -17,6 +17,9 @@ Required properties (SPI):
> - compatible: "google,cros-ec-spi"
> - reg: SPI chip select
>
> +Required properties (RPMSG):
> +- compatible: "google,cros-ec-rpmsg"
> +
> Optional properties (SPI):
> - google,cros-ec-spi-pre-delay: Some implementations of the EC need a little
> time to wake up from sleep before they can receive SPI transfers at a high
> --
> 2.22.0.rc1.257.g3120a18244-goog
>

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]


Attachments:
(No filename) (1.91 kB)
signature.asc (235.00 B)
Download all attachments