2019-05-29 06:50:39

by Anson Huang

Subject: [PATCH] ARM: dts: imx7d-sdb: Make SW2's voltage fixed

From: Anson Huang <[email protected]>

On i.MX7D SDB board, SW2 supplies a lot of peripheral devices,
its voltage should be fixed at 1.8V. The commit 43967d9b5a7c
("ARM: dts: imx7d-sdb: Assign corresponding power supply for LDOs")
assigns SW2 as the supplier of vdd1p0d, and when its comsumers
pcie-phy/mipi-phy try to set the vdd1p0d to 1.0V, regulator core
will also set SW2 to its best(min) voltage to 1.5V, and it will
lead to board reset.

This patch makes SW2's voltage fixed at 1.8V to avoid this issue.

Fixes: 43967d9b5a7c ("ARM: dts: imx7d-sdb: Assign corresponding power supply for LDOs")
Reported-by: Leonard Crestez <[email protected]>
Signed-off-by: Anson Huang <[email protected]>
---
arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
index efc83bc..a5365b8 100644
--- a/arch/arm/boot/dts/imx7d-sdb.dts
+++ b/arch/arm/boot/dts/imx7d-sdb.dts
@@ -263,8 +263,8 @@
};

sw2_reg: sw2 {
- regulator-min-microvolt = <1500000>;
- regulator-max-microvolt = <1850000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-boot-on;
regulator-always-on;
};
--
2.7.4

2019-05-29 10:27:55

by Leonard Crestez

Subject: Re: [PATCH] ARM: dts: imx7d-sdb: Make SW2's voltage fixed

On 29.05.2019 09:49, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> On i.MX7D SDB board, SW2 supplies a lot of peripheral devices,
> its voltage should be fixed at 1.8V. The commit 43967d9b5a7c
> ("ARM: dts: imx7d-sdb: Assign corresponding power supply for LDOs")
> assigns SW2 as the supplier of vdd1p0d, and when its comsumers
> pcie-phy/mipi-phy try to set the vdd1p0d to 1.0V, regulator core
> will also set SW2 to its best(min) voltage to 1.5V, and it will
> lead to board reset.
>
> This patch makes SW2's voltage fixed at 1.8V to avoid this issue.
>
> Fixes: 43967d9b5a7c ("ARM: dts: imx7d-sdb: Assign corresponding power supply for LDOs")
> Reported-by: Leonard Crestez <[email protected]>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Leonard Crestez <[email protected]>

Other boards don't seem to be affected by the original series.

2019-06-05 09:19:49

by Shawn Guo

Subject: Re: [PATCH] ARM: dts: imx7d-sdb: Make SW2's voltage fixed

On Wed, May 29, 2019 at 02:50:56PM +0800, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> On i.MX7D SDB board, SW2 supplies a lot of peripheral devices,
> its voltage should be fixed at 1.8V. The commit 43967d9b5a7c
> ("ARM: dts: imx7d-sdb: Assign corresponding power supply for LDOs")
> assigns SW2 as the supplier of vdd1p0d, and when its comsumers
> pcie-phy/mipi-phy try to set the vdd1p0d to 1.0V, regulator core
> will also set SW2 to its best(min) voltage to 1.5V, and it will
> lead to board reset.
>
> This patch makes SW2's voltage fixed at 1.8V to avoid this issue.
>
> Fixes: 43967d9b5a7c ("ARM: dts: imx7d-sdb: Assign corresponding power supply for LDOs")
> Reported-by: Leonard Crestez <[email protected]>
> Signed-off-by: Anson Huang <[email protected]>

Applied, thanks.