2019-06-06 14:26:03

by Jacopo Mondi

Subject: [PATCH 02/20] dt-bindings: display, renesas,du: Document cmms property

Document the newly added 'cmms' property which accepts a list of phandle
and channel index pairs that point to the CMM units available for each
Display Unit output video channel.

Signed-off-by: Jacopo Mondi <[email protected]>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index aedb22b4d161..100114ef11d5 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -44,6 +44,10 @@ Required Properties:
instance that serves the DU channel, and the channel index identifies the
LIF instance in that VSP.

+ - cmms: A list of phandles to the CMM instances present in the SoC, one
+ for each available DU channel. The property shall not be specified for
+ SoCs that does not provide any CMM (such as V3M and V3H).
+
Required nodes:

The connections to the DU output video ports are modeled using the OF graph
@@ -89,6 +93,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU
<&cpg CPG_MOD 721>;
clock-names = "du.0", "du.1", "du.2", "du.3";
vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
+ cmms = <&cmm0 &cmm1 &cmm2 &cmm3>;

ports {
#address-cells = <1>;
--
2.21.0

2019-06-06 20:48:04

by Laurent Pinchart

Subject: Re: [PATCH 02/20] dt-bindings: display, renesas,du: Document cmms property

Hi Jacopo,

Thank you for the patch.

On Thu, Jun 06, 2019 at 04:22:02PM +0200, Jacopo Mondi wrote:
> Document the newly added 'cmms' property which accepts a list of phandle
> and channel index pairs that point to the CMM units available for each
> Display Unit output video channel.
>
> Signed-off-by: Jacopo Mondi <[email protected]>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
> index aedb22b4d161..100114ef11d5 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -44,6 +44,10 @@ Required Properties:
> instance that serves the DU channel, and the channel index identifies the
> LIF instance in that VSP.
>
> + - cmms: A list of phandles to the CMM instances present in the SoC, one
> + for each available DU channel. The property shall not be specified for
> + SoCs that does not provide any CMM (such as V3M and V3H).

s/does/do/

Reviewed-by: Laurent Pinchart <[email protected]>

> +
> Required nodes:
>
> The connections to the DU output video ports are modeled using the OF graph
> @@ -89,6 +93,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU
> <&cpg CPG_MOD 721>;
> clock-names = "du.0", "du.1", "du.2", "du.3";
> vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
> + cmms = <&cmm0 &cmm1 &cmm2 &cmm3>;
>
> ports {
> #address-cells = <1>;

--
Regards,

Laurent Pinchart