2019-06-06 15:13:50

by Vitor Soares

Subject: [PATCH v2 2/3] i3c: add i3c_get_device_id helper

This helper return the i3c_device_id structure in order the client
have access to the driver data.

Signed-off-by: Vitor Soares <[email protected]>
---
Changes in v2:
move this function to drivers/i3c/device.c

drivers/i3c/device.c | 8 ++++++++
include/linux/i3c/device.h | 1 +
2 files changed, 9 insertions(+)

diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c
index 69cc040..a6d0796 100644
--- a/drivers/i3c/device.c
+++ b/drivers/i3c/device.c
@@ -200,6 +200,14 @@ struct i3c_device *dev_to_i3cdev(struct device *dev)
}
EXPORT_SYMBOL_GPL(dev_to_i3cdev);

+const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev)
+{
+ const struct i3c_driver *i3cdrv = drv_to_i3cdrv(i3cdev->dev.driver);
+
+ return i3cdrv->id_table;
+}
+EXPORT_SYMBOL_GPL(i3c_get_device_id);
+
/**
* i3c_driver_register_with_owner() - register an I3C device driver
*
diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
index 5ecb055..e0415e1 100644
--- a/include/linux/i3c/device.h
+++ b/include/linux/i3c/device.h
@@ -187,6 +187,7 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv)

struct device *i3cdev_to_dev(struct i3c_device *i3cdev);
struct i3c_device *dev_to_i3cdev(struct device *dev);
+const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev);

static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev,
void *data)
--
2.7.4

2019-06-06 18:09:43

by Boris Brezillon

Subject: Re: [PATCH v2 2/3] i3c: add i3c_get_device_id helper

On Thu, 6 Jun 2019 17:12:03 +0200
Vitor Soares <[email protected]> wrote:

> This helper return the i3c_device_id structure in order the client
> have access to the driver data.
>
> Signed-off-by: Vitor Soares <[email protected]>
> ---
> Changes in v2:
> move this function to drivers/i3c/device.c
>
> drivers/i3c/device.c | 8 ++++++++
> include/linux/i3c/device.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c
> index 69cc040..a6d0796 100644
> --- a/drivers/i3c/device.c
> +++ b/drivers/i3c/device.c
> @@ -200,6 +200,14 @@ struct i3c_device *dev_to_i3cdev(struct device *dev)
> }
> EXPORT_SYMBOL_GPL(dev_to_i3cdev);
>
> +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev)
> +{
> + const struct i3c_driver *i3cdrv = drv_to_i3cdrv(i3cdev->dev.driver);
> +
> + return i3cdrv->id_table;
> +}
> +EXPORT_SYMBOL_GPL(i3c_get_device_id);

That's not what I asked. I told you to expose i3c_device_match_id()
which already exists and is in master.c. What you really want is to get
the device_id entry that matches your device, not the first entry in
the table...

> +
> /**
> * i3c_driver_register_with_owner() - register an I3C device driver
> *
> diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
> index 5ecb055..e0415e1 100644
> --- a/include/linux/i3c/device.h
> +++ b/include/linux/i3c/device.h
> @@ -187,6 +187,7 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv)
>
> struct device *i3cdev_to_dev(struct i3c_device *i3cdev);
> struct i3c_device *dev_to_i3cdev(struct device *dev);
> +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev);
>
> static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev,
> void *data)

2019-06-06 18:52:26

by Vitor Soares

Subject: RE: [PATCH v2 2/3] i3c: add i3c_get_device_id helper

Hi Boris,

From: Boris Brezillon <[email protected]>
Date: Thu, Jun 06, 2019 at 16:17:55

> On Thu, 6 Jun 2019 17:12:03 +0200
> Vitor Soares <[email protected]> wrote:
>
> > This helper return the i3c_device_id structure in order the client
> > have access to the driver data.
> >
> > Signed-off-by: Vitor Soares <[email protected]>
> > ---
> > Changes in v2:
> > move this function to drivers/i3c/device.c
> >
> > drivers/i3c/device.c | 8 ++++++++
> > include/linux/i3c/device.h | 1 +
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c
> > index 69cc040..a6d0796 100644
> > --- a/drivers/i3c/device.c
> > +++ b/drivers/i3c/device.c
> > @@ -200,6 +200,14 @@ struct i3c_device *dev_to_i3cdev(struct device *dev)
> > }
> > EXPORT_SYMBOL_GPL(dev_to_i3cdev);
> >
> > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev)
> > +{
> > + const struct i3c_driver *i3cdrv = drv_to_i3cdrv(i3cdev->dev.driver);
> > +
> > + return i3cdrv->id_table;
> > +}
> > +EXPORT_SYMBOL_GPL(i3c_get_device_id);
>
> That's not what I asked. I told you to expose i3c_device_match_id()
> which already exists and is in master.c. What you really want is to get
> the device_id entry that matches your device, not the first entry in
> the table...
>

I didn't see it has the full table.
I will change it.

> > +
> > /**
> > * i3c_driver_register_with_owner() - register an I3C device driver
> > *
> > diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
> > index 5ecb055..e0415e1 100644
> > --- a/include/linux/i3c/device.h
> > +++ b/include/linux/i3c/device.h
> > @@ -187,6 +187,7 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv)
> >
> > struct device *i3cdev_to_dev(struct i3c_device *i3cdev);
> > struct i3c_device *dev_to_i3cdev(struct device *dev);
> > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev);
> >
> > static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev,
> > void *data)