2019-06-07 15:43:43

by Will Deacon

Subject: Re: "arm64: Silence gcc warnings about arch ABI drift" breaks clang

On Fri, Jun 07, 2019 at 11:22:45AM -0400, Qian Cai wrote:
> The linux-next commit "arm64: Silence gcc warnings about arch ABI drift" [1]
> breaks clang build where it screams that unknown option "-Wno-psabi" and
> generates errors below,

So that can be easily fixed with cc-option...

> [1] https://lore.kernel.org/linux-arm-kernel/1559817223-32585-1-git-send-email-D
> [email protected]/
>
> ./drivers/firmware/efi/libstub/arm-stub.stub.o: In function
> `install_memreserve_table':
> ./linux/drivers/firmware/efi/libstub/arm-stub.c:73: undefined reference to
> `__efistub___stack_chk_guard'
> ./linux/drivers/firmware/efi/libstub/arm-stub.c:73: undefined reference to
> `__efistub___stack_chk_guard'
> ./linux/drivers/firmware/efi/libstub/arm-stub.c:93: undefined reference to
> `__efistub___stack_chk_guard'
> ./linux/drivers/firmware/efi/libstub/arm-stub.c:93: undefined reference to
> `__efistub___stack_chk_guard'
> ./linux/drivers/firmware/efi/libstub/arm-stub.c:94: undefined reference to
> `__efistub___stack_chk_fail

... but this looks unrelated. Are you saying you don't see these errors if
you revert Dave's patch?

Will

2019-06-07 17:37:54

by Qian Cai

Subject: Re: "arm64: Silence gcc warnings about arch ABI drift" breaks clang

On Fri, 2019-06-07 at 16:25 +0100, Will Deacon wrote:
> On Fri, Jun 07, 2019 at 11:22:45AM -0400, Qian Cai wrote:
> > The linux-next commit "arm64: Silence gcc warnings about arch ABI drift" [1]
> > breaks clang build where it screams that unknown option "-Wno-psabi" and
> > generates errors below,
>
> So that can be easily fixed with cc-option...
>
> > [1] https://lore.kernel.org/linux-arm-kernel/1559817223-32585-1-git-send-ema
> > il-D
> > [email protected]/
> >
> > ./drivers/firmware/efi/libstub/arm-stub.stub.o: In function
> > `install_memreserve_table':
> > ./linux/drivers/firmware/efi/libstub/arm-stub.c:73: undefined reference to
> > `__efistub___stack_chk_guard'
> > ./linux/drivers/firmware/efi/libstub/arm-stub.c:73: undefined reference to
> > `__efistub___stack_chk_guard'
> > ./linux/drivers/firmware/efi/libstub/arm-stub.c:93: undefined reference to
> > `__efistub___stack_chk_guard'
> > ./linux/drivers/firmware/efi/libstub/arm-stub.c:93: undefined reference to
> > `__efistub___stack_chk_guard'
> > ./linux/drivers/firmware/efi/libstub/arm-stub.c:94: undefined reference to
> > `__efistub___stack_chk_fail
>
> ... but this looks unrelated. Are you saying you don't see these errors if
> you revert Dave's patch?

Yes.