2019-06-01 21:39:37

by Thomas Meyer

Subject: [PATCH] counter: ftm-quaddec: needs HAS_IOMEM

the driver fails for UML with:
drivers/counter/ftm-quaddec.c:301: undefined reference to `devm_ioremap'

Fix it by depending on HAS_IOMEM
---
drivers/counter/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 138ecd8a8fbd..6298344b536b 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -50,6 +50,7 @@ config STM32_LPTIMER_CNT
module will be called stm32-lptimer-cnt.

config FTM_QUADDEC
+ depends on HAS_IOMEM
tristate "Flex Timer Module Quadrature decoder driver"
help
Select this option to enable the Flex Timer Quadrature decoder
--
2.21.0

2019-06-08 13:32:47

by Jonathan Cameron

Subject: Re: [PATCH] counter: ftm-quaddec: needs HAS_IOMEM

On Sat, 1 Jun 2019 23:38:05 +0200
Thomas Meyer <[email protected]> wrote:

> the driver fails for UML with:
> drivers/counter/ftm-quaddec.c:301: undefined reference to `devm_ioremap'
>
> Fix it by depending on HAS_IOMEM
Missing Signed-off-by.

Unfortunately I came across another patch for this before yours so
already have this fixed in the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
> drivers/counter/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 138ecd8a8fbd..6298344b536b 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -50,6 +50,7 @@ config STM32_LPTIMER_CNT
> module will be called stm32-lptimer-cnt.
>
> config FTM_QUADDEC
> + depends on HAS_IOMEM
> tristate "Flex Timer Module Quadrature decoder driver"
> help
> Select this option to enable the Flex Timer Quadrature decoder