2019-06-12 09:52:15

by Matteo Croce

Subject: [PATCH net] mpls: fix af_mpls dependencies for real

Randy reported that selecting MPLS_ROUTING without PROC_FS breaks
the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls
dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select
doesn't recursively handle dependencies.
Change the select into a dependency.

Fixes: c1a9d65954c6 ("mpls: fix af_mpls dependencies")
Reported-by: Randy Dunlap <[email protected]>
Signed-off-by: Matteo Croce <[email protected]>
---
net/mpls/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
index 2b802a48d5a6..d1ad69b7942a 100644
--- a/net/mpls/Kconfig
+++ b/net/mpls/Kconfig
@@ -26,7 +26,7 @@ config NET_MPLS_GSO
config MPLS_ROUTING
tristate "MPLS: routing support"
depends on NET_IP_TUNNEL || NET_IP_TUNNEL=n
- select PROC_SYSCTL
+ depends on PROC_SYSCTL
---help---
Add support for forwarding of mpls packets.

--
2.21.0

2019-06-12 18:08:48

by David Miller

Subject: Re: [PATCH net] mpls: fix af_mpls dependencies for real

From: Matteo Croce <[email protected]>
Date: Wed, 12 Jun 2019 11:50:37 +0200

> Randy reported that selecting MPLS_ROUTING without PROC_FS breaks
> the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls
> dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select
> doesn't recursively handle dependencies.
> Change the select into a dependency.
>
> Fixes: c1a9d65954c6 ("mpls: fix af_mpls dependencies")
> Reported-by: Randy Dunlap <[email protected]>
> Signed-off-by: Matteo Croce <[email protected]>

Applied.