2019-06-13 16:34:54

by Heiko Carstens

[permalink] [raw]
Subject: Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP

On Thu, Jun 13, 2019 at 11:13:55AM +0800, Herbert Xu wrote:
> On Wed, Jun 12, 2019 at 05:08:50PM +0200, Heiko Carstens wrote:
> > On Wed, Jun 12, 2019 at 03:33:02PM +0200, David Hildenbrand wrote:
> > > s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of
> > > -ENODEV in case HW support is not available.
> > >
> > > Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service
> > > ignores this error properly.
> > >
> > > v2 -> v3:
> > > - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP"
> > > -- Also convert pkey_clr2protkey() as requested by Harald
> > > - Add r-b's (thanks!)
> > >
> > > v1 -> v2:
> > > - Include
> > > -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP"
> > > -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP"
> > > -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP"
> > >
> > > Cc: Herbert Xu <[email protected]>
> > > Cc: "David S. Miller" <[email protected]>
> > > Cc: Heiko Carstens <[email protected]>
> > > Cc: Vasily Gorbik <[email protected]>
> > > Cc: Christian Borntraeger <[email protected]>
> > > Cc: Harald Freudenberger <[email protected]>
> > > Cc: Cornelia Huck <[email protected]>
> > >
> > > David Hildenbrand (4):
> > > s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
> > > s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
> > > s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
> > > s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
> >
> > Should I pick these up so they can go upstream via the s390 tree?
>
> Sure Heiko. Thanks!

Ok, all applied. Thanks!