Hey all,
I'm looking into cleaning up ignored warnings in the kernel so we can
remove compiler flags to ignore warnings.
There's an unused variable ('mbox_cmd_name') in xhci-tegra.c. Looks
like it was intended for logging or debugging, but never used. Just
wanted to reach out to ask the best steps for cleaning this up.
If the variable is no longer needed I'd like to send a patch to remove it.
https://github.com/ClangBuiltLinux/linux/issues/533
Thanks,
Nathan Huckleberry
On Thu, Jun 13, 2019 at 11:38:38AM -0700, Nathan Huckleberry wrote:
> Hey all,
>
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There's an unused variable ('mbox_cmd_name') in xhci-tegra.c. Looks
> like it was intended for logging or debugging, but never used. Just
> wanted to reach out to ask the best steps for cleaning this up.
>
> If the variable is no longer needed I'd like to send a patch to remove it.
You never have to ask permission to send a patch :)
On Thu, Jun 13, 2019 at 11:38:38AM -0700, Nathan Huckleberry wrote:
> Hey all,
>
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There's an unused variable ('mbox_cmd_name') in xhci-tegra.c. Looks
> like it was intended for logging or debugging, but never used. Just
> wanted to reach out to ask the best steps for cleaning this up.
>
> If the variable is no longer needed I'd like to send a patch to remove it.
>
> https://github.com/ClangBuiltLinux/linux/issues/533
Feel free to send that patch. If we ever need this debug information
again we can easily add it back by reverting.
Thierry