2019-06-17 14:38:58

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] media: cxd2880: Add missing newline at end of file

"git diff" says:

\ No newline at end of file

after modifying the file.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/media/dvb-frontends/cxd2880/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/cxd2880/Kconfig b/drivers/media/dvb-frontends/cxd2880/Kconfig
index 9d989676e8007264..94a8e0b936b951dd 100644
--- a/drivers/media/dvb-frontends/cxd2880/Kconfig
+++ b/drivers/media/dvb-frontends/cxd2880/Kconfig
@@ -5,4 +5,4 @@ config DVB_CXD2880
depends on DVB_CORE && SPI
default m if !MEDIA_SUBDRV_AUTOSELECT
help
- Say Y when you want to support this frontend.
\ No newline at end of file
+ Say Y when you want to support this frontend.
--
2.17.1


2019-07-08 14:31:13

by Sean Young

[permalink] [raw]
Subject: Re: [PATCH] media: cxd2880: Add missing newline at end of file

On Mon, Jun 17, 2019 at 04:38:01PM +0200, Geert Uytterhoeven wrote:
> "git diff" says:
>
> \ No newline at end of file
>
> after modifying the file.

git diff says this because after patching using the diff output, files
should be byte-for-byte identifical. It does not mean there necessarily
is a problem.

I'm not sure this worth fixing or whether it solves an actual problem;
the Kconfig is parsed correctly.

Sean

>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/media/dvb-frontends/cxd2880/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/cxd2880/Kconfig b/drivers/media/dvb-frontends/cxd2880/Kconfig
> index 9d989676e8007264..94a8e0b936b951dd 100644
> --- a/drivers/media/dvb-frontends/cxd2880/Kconfig
> +++ b/drivers/media/dvb-frontends/cxd2880/Kconfig
> @@ -5,4 +5,4 @@ config DVB_CXD2880
> depends on DVB_CORE && SPI
> default m if !MEDIA_SUBDRV_AUTOSELECT
> help
> - Say Y when you want to support this frontend.
> \ No newline at end of file
> + Say Y when you want to support this frontend.
> --
> 2.17.1