2019-06-17 16:24:06

by Randy Dunlap

Subject: [PATCH] counter: fix ftm-quaddec build error on UML

From: Randy Dunlap <[email protected]>

Fix build error on user-mode Linux, which does not set HAS_IOMEM,
so devm_ioremap() is not available. Fixes this build error:

ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!

Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter driver")

Reported-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Kjeld Flarup <[email protected]>
Cc: Patrick Havelange <[email protected]>
Cc: William Breathitt Gray <[email protected]>
Cc: [email protected]
---
BTW, please fix these lines to have ending '>' characters:
MODULE_AUTHOR("Kjeld Flarup <[email protected]");
MODULE_AUTHOR("Patrick Havelange <[email protected]");

drivers/counter/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- lnx-52-rc5.orig/drivers/counter/Kconfig
+++ lnx-52-rc5/drivers/counter/Kconfig
@@ -51,6 +51,7 @@ config STM32_LPTIMER_CNT

config FTM_QUADDEC
tristate "Flex Timer Module Quadrature decoder driver"
+ depends on HAS_IOMEM
help
Select this option to enable the Flex Timer Quadrature decoder
driver.

2019-06-17 19:57:02

by Richard Weinberger

Subject: Re: [PATCH] counter: fix ftm-quaddec build error on UML

Hi!

----- Ursprüngliche Mail -----
> Von: "Randy Dunlap" <[email protected]>
> An: "linux-kernel" <[email protected]>, [email protected]
> CC: "Geert Uytterhoeven" <[email protected]>, "Kjeld Flarup" <[email protected]>, "Patrick Havelange"
> <[email protected]>, "William Breathitt Gray" <[email protected]>, "richard" <[email protected]>
> Gesendet: Montag, 17. Juni 2019 18:21:40
> Betreff: [PATCH] counter: fix ftm-quaddec build error on UML

> From: Randy Dunlap <[email protected]>
>
> Fix build error on user-mode Linux, which does not set HAS_IOMEM,
> so devm_ioremap() is not available. Fixes this build error:
>
> ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!
>
> Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter
> driver")
>
> Reported-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Randy Dunlap <[email protected]>

AFAICT Patrick fixed this already.

Thanks,
//richard

2019-06-18 07:02:47

by William Breathitt Gray

Subject: Re: [PATCH] counter: fix ftm-quaddec build error on UML

On Mon, Jun 17, 2019 at 09:54:45PM +0200, Richard Weinberger wrote:
> Hi!
>
> ----- Ursprüngliche Mail -----
> > Von: "Randy Dunlap" <[email protected]>
> > An: "linux-kernel" <[email protected]>, [email protected]
> > CC: "Geert Uytterhoeven" <[email protected]>, "Kjeld Flarup" <[email protected]>, "Patrick Havelange"
> > <[email protected]>, "William Breathitt Gray" <[email protected]>, "richard" <[email protected]>
> > Gesendet: Montag, 17. Juni 2019 18:21:40
> > Betreff: [PATCH] counter: fix ftm-quaddec build error on UML
>
> > From: Randy Dunlap <[email protected]>
> >
> > Fix build error on user-mode Linux, which does not set HAS_IOMEM,
> > so devm_ioremap() is not available. Fixes this build error:
> >
> > ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!
> >
> > Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter
> > driver")
> >
> > Reported-by: Geert Uytterhoeven <[email protected]>
> > Signed-off-by: Randy Dunlap <[email protected]>
>
> AFAICT Patrick fixed this already.
>
> Thanks,
> //richard

Yes, commit 0c75376fa395 ("counter/ftm-quaddec: Add missing dependencies
in Kconfig") in Greg KH's staging repository in the staging-linus
branch should address this issue.

William Breathitt Gray