2019-06-18 09:42:23

by Anson Huang

Subject: [PATCH RESEND V2] soc: imx8: Use existing of_root directly

From: Anson Huang <[email protected]>

There is common of_root for reference, no need to find it
from DT again, use of_root directly to make driver simple.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/soc/imx/soc-imx8.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
index ef2406f..34ab993 100644
--- a/drivers/soc/imx/soc-imx8.c
+++ b/drivers/soc/imx/soc-imx8.c
@@ -94,7 +94,6 @@ static int __init imx8_soc_init(void)
{
struct soc_device_attribute *soc_dev_attr;
struct soc_device *soc_dev;
- struct device_node *root;
const struct of_device_id *id;
u32 soc_rev = 0;
const struct imx8_soc_data *data;
@@ -106,12 +105,11 @@ static int __init imx8_soc_init(void)

soc_dev_attr->family = "Freescale i.MX";

- root = of_find_node_by_path("/");
- ret = of_property_read_string(root, "model", &soc_dev_attr->machine);
+ ret = of_property_read_string(of_root, "model", &soc_dev_attr->machine);
if (ret)
goto free_soc;

- id = of_match_node(imx8_soc_match, root);
+ id = of_match_node(imx8_soc_match, of_root);
if (!id) {
ret = -ENODEV;
goto free_soc;
@@ -136,8 +134,6 @@ static int __init imx8_soc_init(void)
goto free_rev;
}

- of_node_put(root);
-
return 0;

free_rev:
@@ -145,7 +141,6 @@ static int __init imx8_soc_init(void)
kfree(soc_dev_attr->revision);
free_soc:
kfree(soc_dev_attr);
- of_node_put(root);
return ret;
}
device_initcall(imx8_soc_init);
--
2.7.4

2019-06-18 13:28:53

by Shawn Guo

Subject: Re: [PATCH RESEND V2] soc: imx8: Use existing of_root directly

On Tue, Jun 18, 2019 at 05:43:38PM +0800, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> There is common of_root for reference, no need to find it
> from DT again, use of_root directly to make driver simple.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied, thanks.