2019-06-20 15:04:16

by 王金浦

Subject: [PATCH v4 01/25] sysfs: export sysfs_remove_file_self()

From: Roman Pen <[email protected]>

Function is going to be used in transport over RDMA module
in subsequent patches.

Signed-off-by: Roman Pen <[email protected]>
Acked-by: Tejun Heo <[email protected]>
Cc: [email protected]
---
fs/sysfs/file.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 130fc6fbcc03..1ff4672d7746 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -492,6 +492,7 @@ bool sysfs_remove_file_self(struct kobject *kobj, const struct attribute *attr)
kernfs_put(kn);
return ret;
}
+EXPORT_SYMBOL_GPL(sysfs_remove_file_self);

void sysfs_remove_files(struct kobject *kobj, const struct attribute * const *ptr)
{
--
2.17.1

2019-09-25 21:01:17

by Bart Van Assche

Subject: Re: [PATCH v4 01/25] sysfs: export sysfs_remove_file_self()

On 6/20/19 8:03 AM, Jack Wang wrote:
> Function is going to be used in transport over RDMA module
> in subsequent patches.

It seems like several words are missing from this patch description.

Bart.

2019-09-26 09:25:14

by Danil Kipnis

Subject: Re: [PATCH v4 01/25] sysfs: export sysfs_remove_file_self()

On Mon, Sep 23, 2019 at 7:21 PM Bart Van Assche <[email protected]> wrote:
>
> On 6/20/19 8:03 AM, Jack Wang wrote:
> > Function is going to be used in transport over RDMA module
> > in subsequent patches.
>
> It seems like several words are missing from this patch description.
Will extend with corresponding description of the function from
fs/sysfs/file.c and explanation why we need it.