2019-06-22 22:26:40

by Tiezhu Yang

Subject: [PATCH v2] kexec: fix warnig of crash_zero_bytes in crash.c

Fix the following sparse warning:

arch/x86/kernel/crash.c:59:15:
warning: symbol 'crash_zero_bytes' was not declared. Should it be static?

First, make crash_zero_bytes static. In addition, crash_zero_bytes
is used when CONFIG_KEXEC_FILE is set, so make it only available
under CONFIG_KEXEC_FILE. Otherwise, if CONFIG_KEXEC_FILE is not set,
the following warning will appear when make crash_zero_bytes static:

arch/x86/kernel/crash.c:59:22:
warning: ??crash_zero_bytes?? defined but not used [-Wunused-variable]

Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
Signed-off-by: Tiezhu Yang <[email protected]>
Cc: Vivek Goyal <[email protected]>
---
arch/x86/kernel/crash.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 576b2e1..f13480e 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -56,7 +56,9 @@ struct crash_memmap_data {
*/
crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss = NULL;
EXPORT_SYMBOL_GPL(crash_vmclear_loaded_vmcss);
-unsigned long crash_zero_bytes;
+#ifdef CONFIG_KEXEC_FILE
+static unsigned long crash_zero_bytes;
+#endif

static inline void cpu_crash_vmclear_loaded_vmcss(void)
{
--
1.8.3.1

2019-06-24 01:45:06

by Dave Young

Subject: Re: [PATCH v2] kexec: fix warnig of crash_zero_bytes in crash.c

On 06/23/19 at 06:24am, Tiezhu Yang wrote:
> Fix the following sparse warning:
>
> arch/x86/kernel/crash.c:59:15:
> warning: symbol 'crash_zero_bytes' was not declared. Should it be static?
>
> First, make crash_zero_bytes static. In addition, crash_zero_bytes
> is used when CONFIG_KEXEC_FILE is set, so make it only available
> under CONFIG_KEXEC_FILE. Otherwise, if CONFIG_KEXEC_FILE is not set,
> the following warning will appear when make crash_zero_bytes static:
>
> arch/x86/kernel/crash.c:59:22:
> warning: ‘crash_zero_bytes’ defined but not used [-Wunused-variable]
>
> Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
> Signed-off-by: Tiezhu Yang <[email protected]>
> Cc: Vivek Goyal <[email protected]>
> ---
> arch/x86/kernel/crash.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> index 576b2e1..f13480e 100644
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c
> @@ -56,7 +56,9 @@ struct crash_memmap_data {
> */
> crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss = NULL;
> EXPORT_SYMBOL_GPL(crash_vmclear_loaded_vmcss);
> -unsigned long crash_zero_bytes;
> +#ifdef CONFIG_KEXEC_FILE
> +static unsigned long crash_zero_bytes;
> +#endif
>
> static inline void cpu_crash_vmclear_loaded_vmcss(void)
> {
> --
> 1.8.3.1

Acked-by: Dave Young <[email protected]>

Thanks
Dave

2019-06-24 01:54:33

by Dave Young

Subject: Re: [PATCH v2] kexec: fix warnig of crash_zero_bytes in crash.c

On 06/24/19 at 09:35am, Dave Young wrote:
> On 06/23/19 at 06:24am, Tiezhu Yang wrote:
> > Fix the following sparse warning:
> >
> > arch/x86/kernel/crash.c:59:15:
> > warning: symbol 'crash_zero_bytes' was not declared. Should it be static?
> >
> > First, make crash_zero_bytes static. In addition, crash_zero_bytes
> > is used when CONFIG_KEXEC_FILE is set, so make it only available
> > under CONFIG_KEXEC_FILE. Otherwise, if CONFIG_KEXEC_FILE is not set,
> > the following warning will appear when make crash_zero_bytes static:
> >
> > arch/x86/kernel/crash.c:59:22:
> > warning: ‘crash_zero_bytes’ defined but not used [-Wunused-variable]
> >
> > Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
> > Signed-off-by: Tiezhu Yang <[email protected]>
> > Cc: Vivek Goyal <[email protected]>
> > ---
> > arch/x86/kernel/crash.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> > index 576b2e1..f13480e 100644
> > --- a/arch/x86/kernel/crash.c
> > +++ b/arch/x86/kernel/crash.c
> > @@ -56,7 +56,9 @@ struct crash_memmap_data {
> > */
> > crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss = NULL;
> > EXPORT_SYMBOL_GPL(crash_vmclear_loaded_vmcss);
> > -unsigned long crash_zero_bytes;
> > +#ifdef CONFIG_KEXEC_FILE
> > +static unsigned long crash_zero_bytes;
> > +#endif
> >
> > static inline void cpu_crash_vmclear_loaded_vmcss(void)
> > {
> > --
> > 1.8.3.1
>
> Acked-by: Dave Young <[email protected]>

BTW, a soft reminder, for kexec patches, it would be better to cc kexec mail
list.

>
> Thanks
> Dave
>

2019-06-24 05:43:33

by Tiezhu Yang

Subject: Re:Re: [PATCH v2] kexec: fix warnig of crash_zero_bytes in crash.c

At 2019-06-24 09:53:59, "Dave Young" <[email protected]> wrote:
>On 06/24/19 at 09:35am, Dave Young wrote:
>> On 06/23/19 at 06:24am, Tiezhu Yang wrote:
>> > Fix the following sparse warning:
>> >
>> > arch/x86/kernel/crash.c:59:15:
>> > warning: symbol 'crash_zero_bytes' was not declared. Should it be static?
>> >
>> > First, make crash_zero_bytes static. In addition, crash_zero_bytes
>> > is used when CONFIG_KEXEC_FILE is set, so make it only available
>> > under CONFIG_KEXEC_FILE. Otherwise, if CONFIG_KEXEC_FILE is not set,
>> > the following warning will appear when make crash_zero_bytes static:
>> >
>> > arch/x86/kernel/crash.c:59:22:
>> > warning: ??crash_zero_bytes?? defined but not used [-Wunused-variable]
>> >
>> > Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
>> > Signed-off-by: Tiezhu Yang <[email protected]>
>> > Cc: Vivek Goyal <[email protected]>
>> > ---
>> > arch/x86/kernel/crash.c | 4 +++-
>> > 1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
>> > index 576b2e1..f13480e 100644
>> > --- a/arch/x86/kernel/crash.c
>> > +++ b/arch/x86/kernel/crash.c
>> > @@ -56,7 +56,9 @@ struct crash_memmap_data {
>> > */
>> > crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss = NULL;
>> > EXPORT_SYMBOL_GPL(crash_vmclear_loaded_vmcss);
>> > -unsigned long crash_zero_bytes;
>> > +#ifdef CONFIG_KEXEC_FILE
>> > +static unsigned long crash_zero_bytes;
>> > +#endif
>> >
>> > static inline void cpu_crash_vmclear_loaded_vmcss(void)
>> > {
>> > --
>> > 1.8.3.1
>>
>> Acked-by: Dave Young <[email protected]>
>
>BTW, a soft reminder, for kexec patches, it would be better to cc kexec mail
>list.

Thank you for reminding me of that, I will resend it with a Cc to [email protected].

Thanks,

>
>>
>> Thanks
>> Dave
>>