2019-06-24 05:37:46

by Masanari Iida

Subject: [PATCH] node: Fix warning while make xmldocs

This patch fixes following warning while make xmldocs.
./drivers/base/node.c:690: warning: Excess function parameter
'mem_node' description in 'register_memory_node_under_compute_node'
./drivers/base/node.c:690: warning: Excess function parameter
'cpu_node' description in 'register_memory_node_under_compute_node'

Signed-off-by: Masanari Iida <[email protected]>
---
drivers/base/node.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index d8c02e65df68..944ee45d122f 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -673,8 +673,8 @@ int register_cpu_under_node(unsigned int cpu, unsigned int nid)
/**
* register_memory_node_under_compute_node - link memory node to its compute
* node for a given access class.
- * @mem_node: Memory node number
- * @cpu_node: Cpu node number
+ * @mem_nid: Memory node identifier
+ * @cpu_nid: Cpu node identifier
* @access: Access class to register
*
* Description:
--
2.22.0.190.ga6a95cd1b46e

2019-06-24 08:45:16

by Rafael J. Wysocki

Subject: Re: [PATCH] node: Fix warning while make xmldocs

On Mon, Jun 24, 2019 at 5:58 AM Masanari Iida <[email protected]> wrote:
>
> This patch fixes following warning while make xmldocs.
> ./drivers/base/node.c:690: warning: Excess function parameter
> 'mem_node' description in 'register_memory_node_under_compute_node'
> ./drivers/base/node.c:690: warning: Excess function parameter
> 'cpu_node' description in 'register_memory_node_under_compute_node'
>
> Signed-off-by: Masanari Iida <[email protected]>

Reviewed-by: Rafael J. Wysocki <[email protected]>

> ---
> drivers/base/node.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index d8c02e65df68..944ee45d122f 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -673,8 +673,8 @@ int register_cpu_under_node(unsigned int cpu, unsigned int nid)
> /**
> * register_memory_node_under_compute_node - link memory node to its compute
> * node for a given access class.
> - * @mem_node: Memory node number
> - * @cpu_node: Cpu node number
> + * @mem_nid: Memory node identifier
> + * @cpu_nid: Cpu node identifier
> * @access: Access class to register
> *
> * Description:
> --
> 2.22.0.190.ga6a95cd1b46e
>

2019-07-03 19:21:31

by Greg Kroah-Hartman

Subject: Re: [PATCH] driver core: node: Fix warning while make xmldocs

On Mon, Jun 24, 2019 at 12:58:07PM +0900, Masanari Iida wrote:
> This patch fixes following warning while make xmldocs.
> ./drivers/base/node.c:690: warning: Excess function parameter
> 'mem_node' description in 'register_memory_node_under_compute_node'
> ./drivers/base/node.c:690: warning: Excess function parameter
> 'cpu_node' description in 'register_memory_node_under_compute_node'
>
> Signed-off-by: Masanari Iida <[email protected]>
> Reviewed-by: Rafael J. Wysocki <[email protected]>
> ---
> drivers/base/node.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Someone sent this patch before you did, sorry.

greg k-h