2019-06-26 10:39:29

by Guido Günther

[permalink] [raw]
Subject: [PATCH v2 0/4] drm/panel: jh057n0090: Add regulators and drop magic value in init

Fix the omission of a regulators for the recently added panel and make sure all
dsi commands start with a command instead of one having a magic constant (which
already caused confusion).

Also adds a mail alias to the panel's MAINTAINER entry to reduce the bus
factor.

Changes from v1:
* As per review comments from Sam Ravnborg:
- Print error on devm_regulator_get() failres
- Fix typos in commit messages
* Print an error on regulator_enable()
* Disable vcc if iovcc fails to enable

Guido Günther (4):
MAINTAINERS: Add Purism mail alias as reviewer for their devkit's
panel
drm/panel: jh057n00900: Don't use magic constant
dt-bindings: display/panel: jh057n00900: Document power supply
properties
drm/panel: jh057n00900: Add regulator support

.../display/panel/rocktech,jh057n00900.txt | 5 +++
MAINTAINERS | 1 +
.../drm/panel/panel-rocktech-jh057n00900.c | 44 ++++++++++++++++++-
3 files changed, 49 insertions(+), 1 deletion(-)

--
2.20.1


2019-06-26 12:43:29

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] drm/panel: jh057n0090: Add regulators and drop magic value in init

Hi Guido.

On Wed, Jun 26, 2019 at 12:37:47PM +0200, Guido G?nther wrote:
> Fix the omission of a regulators for the recently added panel and make sure all
> dsi commands start with a command instead of one having a magic constant (which
> already caused confusion).
>
> Also adds a mail alias to the panel's MAINTAINER entry to reduce the bus
> factor.
>
> Changes from v1:
> * As per review comments from Sam Ravnborg:
> - Print error on devm_regulator_get() failres
> - Fix typos in commit messages
> * Print an error on regulator_enable()
> * Disable vcc if iovcc fails to enable
>
> Guido G?nther (4):
> MAINTAINERS: Add Purism mail alias as reviewer for their devkit's
> panel
> drm/panel: jh057n00900: Don't use magic constant
> dt-bindings: display/panel: jh057n00900: Document power supply
> properties
> drm/panel: jh057n00900: Add regulator support

Patches applied to drm-misc-next and pushed out

Sam

2019-06-26 13:16:13

by Guido Günther

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] drm/panel: jh057n0090: Add regulators and drop magic value in init

Hi,
On Wed, Jun 26, 2019 at 02:41:39PM +0200, Sam Ravnborg wrote:
> Hi Guido.
>
> On Wed, Jun 26, 2019 at 12:37:47PM +0200, Guido G?nther wrote:
> > Fix the omission of a regulators for the recently added panel and make sure all
> > dsi commands start with a command instead of one having a magic constant (which
> > already caused confusion).
> >
> > Also adds a mail alias to the panel's MAINTAINER entry to reduce the bus
> > factor.
> >
> > Changes from v1:
> > * As per review comments from Sam Ravnborg:
> > - Print error on devm_regulator_get() failres
> > - Fix typos in commit messages
> > * Print an error on regulator_enable()
> > * Disable vcc if iovcc fails to enable
> >
> > Guido G?nther (4):
> > MAINTAINERS: Add Purism mail alias as reviewer for their devkit's
> > panel
> > drm/panel: jh057n00900: Don't use magic constant
> > dt-bindings: display/panel: jh057n00900: Document power supply
> > properties
> > drm/panel: jh057n00900: Add regulator support
>
> Patches applied to drm-misc-next and pushed out

Thank you!
-- Guido

>
> Sam
>