Hi Linus,
In commit
99fd24aa4a45 ("pinctrl: mediatek: Ignore interrupts that are wake only during resume")
Fixes tag
Fixes: bf22ff45bed ("genirq: Avoid unnecessary low level irq function calls")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
On Wed, Jun 26, 2019 at 3:50 PM Stephen Rothwell <[email protected]> wrote:
> In commit
>
> 99fd24aa4a45 ("pinctrl: mediatek: Ignore interrupts that are wake only during resume")
>
> Fixes tag
>
> Fixes: bf22ff45bed ("genirq: Avoid unnecessary low level irq function calls")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
Thanks Stephen, fixed this.
Yours,
Linus Walleij
On Wed, Jun 26, 2019 at 10:11 PM Linus Walleij <[email protected]> wrote:
>
> On Wed, Jun 26, 2019 at 3:50 PM Stephen Rothwell <[email protected]> wrote:
>
> > In commit
> >
> > 99fd24aa4a45 ("pinctrl: mediatek: Ignore interrupts that are wake only during resume")
> >
> > Fixes tag
> >
> > Fixes: bf22ff45bed ("genirq: Avoid unnecessary low level irq function calls")
> >
> > has these problem(s):
> >
> > - SHA1 should be at least 12 digits long
> > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > or later) just making sure it is not set (or set to "auto").
>
> Thanks Stephen, fixed this.
Ouch, sorry, for some reasons I thought it was 10, not 12...
>
> Yours,
> Linus Walleij
Hi Nicolas,
On Thu, 27 Jun 2019 08:32:34 +0800 Nicolas Boichat <[email protected]> wrote:
>
> Ouch, sorry, for some reasons I thought it was 10, not 12...
It used to be 10, but will slowly grow over time. That's why setting
core.abbrev to "auto" is best (or leaving it unset).
--
Cheers,
Stephen Rothwell
On Thu, Jun 27, 2019 at 9:48 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi Nicolas,
>
> On Thu, 27 Jun 2019 08:32:34 +0800 Nicolas Boichat <[email protected]> wrote:
> >
> > Ouch, sorry, for some reasons I thought it was 10, not 12...
>
> It used to be 10, but will slowly grow over time. That's why setting
> core.abbrev to "auto" is best (or leaving it unset).
I'm not that smart, I count the digits manually ,-( Anyway, TIL `git
log --pretty=fixes` and I'll use that in the future, thanks. And my
"auto" setting uses 16 digits, it's ok to use longer ids, right?
BTW Documentation/process/submitting-patches.rst on linux-next/master
still says to hardcode to 12.
Thanks,
>
> --
> Cheers,
> Stephen Rothwell
Hi Nicolas,
On Thu, 27 Jun 2019 09:57:13 +0800 Nicolas Boichat <[email protected]> wrote:
>
> I'm not that smart, I count the digits manually ,-( Anyway, TIL `git
> log --pretty=fixes` and I'll use that in the future, thanks. And my
> "auto" setting uses 16 digits, it's ok to use longer ids, right?
Yeah, more is ok (but not too many more :-)).
> BTW Documentation/process/submitting-patches.rst on linux-next/master
> still says to hardcode to 12.
Rats!
--
Cheers,
Stephen Rothwell