2019-06-28 22:09:25

by Andi Kleen

[permalink] [raw]
Subject: [PATCH] perf tools: Fix typos / broken sentences

From: Andi Kleen <[email protected]>

- Fix a typo in the man page
- Fix a tip that doesn't make any sense.

Signed-off-by: Andi Kleen <[email protected]>
---
tools/perf/Documentation/perf-report.txt | 2 +-
tools/perf/Documentation/tips.txt | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 8c4372819e11..987261d158d4 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -89,7 +89,7 @@ OPTIONS
- socket: processor socket number the task ran at the time of sample
- srcline: filename and line number executed at the time of sample. The
DWARF debugging info must be provided.
- - srcfile: file name of the source file of the same. Requires dwarf
+ - srcfile: file name of the source file of the samples. Requires dwarf
information.
- weight: Event specific weight, e.g. memory latency or transaction
abort cost. This is the global weight.
diff --git a/tools/perf/Documentation/tips.txt b/tools/perf/Documentation/tips.txt
index 869965d629ce..825745a645c1 100644
--- a/tools/perf/Documentation/tips.txt
+++ b/tools/perf/Documentation/tips.txt
@@ -38,6 +38,6 @@ To report cacheline events from previous recording: perf c2c report
To browse sample contexts use perf report --sample 10 and select in context menu
To separate samples by time use perf report --sort time,overhead,sym
To set sample time separation other than 100ms with --sort time use --time-quantum
-Add -I to perf report to sample register values visible in perf report context.
+Add -I to perf record to sample register values, which will be visible in perf report sample context.
To show IPC for sampling periods use perf record -e '{cycles,instructions}:S' and then browse context
To show context switches in perf report sample context add --switch-events to perf record.
--
2.20.1


2019-07-02 15:59:34

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH] perf tools: Fix typos / broken sentences

Em Fri, Jun 28, 2019 at 03:09:00PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <[email protected]>
>
> - Fix a typo in the man page
> - Fix a tip that doesn't make any sense.

Thanks, applied.

- Arnaldo

> Signed-off-by: Andi Kleen <[email protected]>
> ---
> tools/perf/Documentation/perf-report.txt | 2 +-
> tools/perf/Documentation/tips.txt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index 8c4372819e11..987261d158d4 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -89,7 +89,7 @@ OPTIONS
> - socket: processor socket number the task ran at the time of sample
> - srcline: filename and line number executed at the time of sample. The
> DWARF debugging info must be provided.
> - - srcfile: file name of the source file of the same. Requires dwarf
> + - srcfile: file name of the source file of the samples. Requires dwarf
> information.
> - weight: Event specific weight, e.g. memory latency or transaction
> abort cost. This is the global weight.
> diff --git a/tools/perf/Documentation/tips.txt b/tools/perf/Documentation/tips.txt
> index 869965d629ce..825745a645c1 100644
> --- a/tools/perf/Documentation/tips.txt
> +++ b/tools/perf/Documentation/tips.txt
> @@ -38,6 +38,6 @@ To report cacheline events from previous recording: perf c2c report
> To browse sample contexts use perf report --sample 10 and select in context menu
> To separate samples by time use perf report --sort time,overhead,sym
> To set sample time separation other than 100ms with --sort time use --time-quantum
> -Add -I to perf report to sample register values visible in perf report context.
> +Add -I to perf record to sample register values, which will be visible in perf report sample context.
> To show IPC for sampling periods use perf record -e '{cycles,instructions}:S' and then browse context
> To show context switches in perf report sample context add --switch-events to perf record.
> --
> 2.20.1

--

- Arnaldo

Subject: [tip:perf/core] perf tools: Fix typos / broken sentences

Commit-ID: 734ac47e23aee12e1c16a4dd52d7c1cb893eaf6c
Gitweb: https://git.kernel.org/tip/734ac47e23aee12e1c16a4dd52d7c1cb893eaf6c
Author: Andi Kleen <[email protected]>
AuthorDate: Fri, 28 Jun 2019 15:09:00 -0700
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 2 Jul 2019 16:08:16 -0300

perf tools: Fix typos / broken sentences

- Fix a typo in the man page
- Fix a tip that doesn't make any sense.

Signed-off-by: Andi Kleen <[email protected]>
Cc: Jiri Olsa <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/Documentation/perf-report.txt | 2 +-
tools/perf/Documentation/tips.txt | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 8c4372819e11..987261d158d4 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -89,7 +89,7 @@ OPTIONS
- socket: processor socket number the task ran at the time of sample
- srcline: filename and line number executed at the time of sample. The
DWARF debugging info must be provided.
- - srcfile: file name of the source file of the same. Requires dwarf
+ - srcfile: file name of the source file of the samples. Requires dwarf
information.
- weight: Event specific weight, e.g. memory latency or transaction
abort cost. This is the global weight.
diff --git a/tools/perf/Documentation/tips.txt b/tools/perf/Documentation/tips.txt
index 869965d629ce..825745a645c1 100644
--- a/tools/perf/Documentation/tips.txt
+++ b/tools/perf/Documentation/tips.txt
@@ -38,6 +38,6 @@ To report cacheline events from previous recording: perf c2c report
To browse sample contexts use perf report --sample 10 and select in context menu
To separate samples by time use perf report --sort time,overhead,sym
To set sample time separation other than 100ms with --sort time use --time-quantum
-Add -I to perf report to sample register values visible in perf report context.
+Add -I to perf record to sample register values, which will be visible in perf report sample context.
To show IPC for sampling periods use perf record -e '{cycles,instructions}:S' and then browse context
To show context switches in perf report sample context add --switch-events to perf record.