2019-07-02 11:43:04

by Andra Danciu

[permalink] [raw]
Subject: [PATCH] arm64: dts: imx8mq: Add sai6 node

Cc: Daniel Baluta <[email protected]>
Signed-off-by: Andra Danciu <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index d09b808eff87..1ff664523f56 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -278,6 +278,20 @@
#size-cells = <1>;
ranges = <0x30000000 0x30000000 0x400000>;

+ sai6: sai@30030000 {
+ compatible = "fsl,imx8mq-sai",
+ "fsl,imx6sx-sai";
+ reg = <0x30030000 0x10000>;
+ interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_SAI6_IPG>,
+ <&clk IMX8MQ_CLK_SAI6_ROOT>,
+ <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
gpio1: gpio@30200000 {
compatible = "fsl,imx8mq-gpio", "fsl,imx35-gpio";
reg = <0x30200000 0x10000>;
--
2.11.0


2019-07-02 11:46:28

by Abel Vesa

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: imx8mq: Add sai6 node

On 19-07-02 14:41:02, Andra Danciu wrote:

Missing commit message here. Please add one.

> Cc: Daniel Baluta <[email protected]>
> Signed-off-by: Andra Danciu <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index d09b808eff87..1ff664523f56 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -278,6 +278,20 @@
> #size-cells = <1>;
> ranges = <0x30000000 0x30000000 0x400000>;
>
> + sai6: sai@30030000 {
> + compatible = "fsl,imx8mq-sai",
> + "fsl,imx6sx-sai";
> + reg = <0x30030000 0x10000>;
> + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk IMX8MQ_CLK_SAI6_IPG>,
> + <&clk IMX8MQ_CLK_SAI6_ROOT>,
> + <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>;
> + dma-names = "rx", "tx";
> + status = "disabled";
> + };
> +
> gpio1: gpio@30200000 {
> compatible = "fsl,imx8mq-gpio", "fsl,imx35-gpio";
> reg = <0x30200000 0x10000>;
> --
> 2.11.0
>

2019-07-02 12:42:30

by Daniel Baluta

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: imx8mq: Add sai6 node

On Tue, Jul 2, 2019 at 2:46 PM Abel Vesa <[email protected]> wrote:
>
> On 19-07-02 14:41:02, Andra Danciu wrote:
>
> Missing commit message here. Please add one.

Agree. Also, please add SAI3. As you noticed our pico pi board has
pins exposed on for SAI2/SAI3.

As for the description you can say:

SAI3/6 supports up to 2-channels TX (1 dataline) and 2-channels RX (1 dataline).

>
> > Cc: Daniel Baluta <[email protected]>
> > Signed-off-by: Andra Danciu <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index d09b808eff87..1ff664523f56 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -278,6 +278,20 @@
> > #size-cells = <1>;
> > ranges = <0x30000000 0x30000000 0x400000>;
> >
> > + sai6: sai@30030000 {
> > + compatible = "fsl,imx8mq-sai",
> > + "fsl,imx6sx-sai";
> > + reg = <0x30030000 0x10000>;
> > + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_SAI6_IPG>,
> > + <&clk IMX8MQ_CLK_SAI6_ROOT>,
> > + <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>;
> > + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> > + dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>;
> > + dma-names = "rx", "tx";
> > + status = "disabled";
> > + };
> > +
> > gpio1: gpio@30200000 {
> > compatible = "fsl,imx8mq-gpio", "fsl,imx35-gpio";
> > reg = <0x30200000 0x10000>;
> > --
> > 2.11.0
> >