2019-07-03 16:31:48

by Fuqian Huang

Subject: [PATCH v2 19/35] pcmcia: Use kmemdup rather than duplicating its implementation

kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.

Signed-off-by: Fuqian Huang <[email protected]>
---
Changes in v2:
- Fix a typo in commit message (memset -> memcpy)

drivers/pcmcia/cistpl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c
index abd029945cc8..eff91726f121 100644
--- a/drivers/pcmcia/cistpl.c
+++ b/drivers/pcmcia/cistpl.c
@@ -414,14 +414,13 @@ int pcmcia_replace_cis(struct pcmcia_socket *s,
}
mutex_lock(&s->ops_mutex);
kfree(s->fake_cis);
- s->fake_cis = kmalloc(len, GFP_KERNEL);
+ s->fake_cis = kmemdup(data, len, GFP_KERNEL);
if (s->fake_cis == NULL) {
dev_warn(&s->dev, "no memory to replace CIS\n");
mutex_unlock(&s->ops_mutex);
return -ENOMEM;
}
s->fake_cis_len = len;
- memcpy(s->fake_cis, data, len);
dev_info(&s->dev, "Using replacement CIS\n");
mutex_unlock(&s->ops_mutex);
return 0;
--
2.11.0

2019-07-03 17:43:08

by Dominik Brodowski

Subject: Re: [PATCH v2 19/35] pcmcia: Use kmemdup rather than duplicating its implementation

On Thu, Jul 04, 2019 at 12:29:43AM +0800, Fuqian Huang wrote:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
>
> Signed-off-by: Fuqian Huang <[email protected]>
Acked-by: Dominik Brodowski <[email protected]>

Thanks,
Dominik