2019-07-04 02:37:31

by Fuqian Huang

Subject: [Patch v2 06/10] iommu: using dev_get_drvdata directly

Several drivers cast a struct device pointer to a struct
platform_device pointer only to then call platform_get_drvdata().
To improve readability, these constructs can be simplified
by using dev_get_drvdata() directly.

Signed-off-by: Fuqian Huang <[email protected]>
---
Changes in v2:
- Make the commit message more clearly.

drivers/iommu/omap-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 62f9c61338a5..c638f7795735 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -36,7 +36,7 @@
static const struct iommu_ops omap_iommu_ops;

#define to_iommu(dev) \
- ((struct omap_iommu *)platform_get_drvdata(to_platform_device(dev)))
+ ((struct omap_iommu *)dev_get_drvdata(dev))

/* bitmap of the page sizes currently supported */
#define OMAP_IOMMU_PGSIZES (SZ_4K | SZ_64K | SZ_1M | SZ_16M)
--
2.11.0

2019-07-04 08:14:02

by Joerg Roedel

Subject: Re: [Patch v2 06/10] iommu: using dev_get_drvdata directly

On Thu, Jul 04, 2019 at 10:36:20AM +0800, Fuqian Huang wrote:
> #define to_iommu(dev) \
> - ((struct omap_iommu *)platform_get_drvdata(to_platform_device(dev)))
> + ((struct omap_iommu *)dev_get_drvdata(dev))

A similar change is already queued for v5.3.