2019-07-04 09:36:38

by Anson Huang

[permalink] [raw]
Subject: [PATCH V2 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

From: Anson Huang <[email protected]>

i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible
property and related info to support i.MX8MM.

Signed-off-by: Anson Huang <[email protected]>
---
New patch.
---
Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
index 13e0951..bc24c45 100644
--- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
+++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
@@ -7,7 +7,7 @@ controller binding usage.
Required properties:
- compatible:
- For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
- - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
+ - For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"
- reg: should be register base and length as documented in the
datasheet
- interrupts: Should contain SRC interrupt
@@ -47,4 +47,4 @@ Example:

For list of all valid reset indices see
<dt-bindings/reset/imx7-reset.h> for i.MX7 and
-<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ
+<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ/i.MX8MM
--
2.7.4


2019-07-04 09:37:32

by Anson Huang

[permalink] [raw]
Subject: [PATCH V2 2/2] arm64: dts: imx8mm: Add "fsl,imx8mq-src" as src's fallback compatible

From: Anson Huang <[email protected]>

i.MX8MM can reuse i.MX8MQ's src driver, add "fsl,imx8mq-src" as
src's fallback compatible to enable it.

Signed-off-by: Anson Huang <[email protected]>
Reviewed-by: Philipp Zabel <[email protected]>
---
No changes.
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 172bb6f..1870c89 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -520,7 +520,7 @@
};

src: reset-controller@30390000 {
- compatible = "fsl,imx8mm-src", "syscon";
+ compatible = "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon";
reg = <0x30390000 0x10000>;
interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
#reset-cells = <1>;
--
2.7.4

2019-07-04 09:43:18

by Philipp Zabel

[permalink] [raw]
Subject: Re: [PATCH V2 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

On Thu, 2019-07-04 at 17:25 +0800, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible
> property and related info to support i.MX8MM.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> New patch.
> ---
> Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> index 13e0951..bc24c45 100644
> --- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> +++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> @@ -7,7 +7,7 @@ controller binding usage.
> Required properties:
> - compatible:
> - For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
> - - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
> + - For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"

Please still add the "fsl,imx8mm-src" for i.MX8MM, just in case a
significant difference is discovered later.

regards
Philipp

2019-07-04 09:47:40

by Anson Huang

[permalink] [raw]
Subject: RE: [PATCH V2 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

Hi, Philipp

> On Thu, 2019-07-04 at 17:25 +0800, [email protected] wrote:
> > From: Anson Huang <[email protected]>
> >
> > i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible
> > property and related info to support i.MX8MM.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> > ---
> > New patch.
> > ---
> > Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > index 13e0951..bc24c45 100644
> > --- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > +++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > @@ -7,7 +7,7 @@ controller binding usage.
> > Required properties:
> > - compatible:
> > - For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
> > - - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
> > + - For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"
>
> Please still add the "fsl,imx8mm-src" for i.MX8MM, just in case a significant
> difference is discovered later.

OK, then I will add a new line as below:

For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon"

Anson.

>
> regards
> Philipp

2019-07-04 09:49:56

by Philipp Zabel

[permalink] [raw]
Subject: Re: [PATCH V2 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

On Thu, 2019-07-04 at 09:46 +0000, Anson Huang wrote:
> Hi, Philipp
>
> > On Thu, 2019-07-04 at 17:25 +0800, [email protected] wrote:
> > > From: Anson Huang <[email protected]>
> > >
> > > i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible
> > > property and related info to support i.MX8MM.
> > >
> > > Signed-off-by: Anson Huang <[email protected]>
> > > ---
> > > New patch.
> > > ---
> > > Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > index 13e0951..bc24c45 100644
> > > --- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > +++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > @@ -7,7 +7,7 @@ controller binding usage.
> > > Required properties:
> > > - compatible:
> > > - For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
> > > - - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
> > > + - For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"
> >
> > Please still add the "fsl,imx8mm-src" for i.MX8MM, just in case a significant
> > difference is discovered later.
>
> OK, then I will add a new line as below:
>
> For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon"

Yes, that looks good, thanks.

regards
Philipp