2019-07-08 12:00:23

by Keerthy

Subject: [PATCH] gpio: davinci: silence error prints in case of EPROBE_DEFER

Silence error prints in case of EPROBE_DEFER. This avoids
multiple/duplicate defer prints during boot.

Signed-off-by: Keerthy <[email protected]>
---
drivers/gpio/gpio-davinci.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index fc494a84a29d..e0b025689625 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -238,8 +238,9 @@ static int davinci_gpio_probe(struct platform_device *pdev)
for (i = 0; i < nirq; i++) {
chips->irqs[i] = platform_get_irq(pdev, i);
if (chips->irqs[i] < 0) {
- dev_info(dev, "IRQ not populated, err = %d\n",
- chips->irqs[i]);
+ if (chips->irqs[i] != -EPROBE_DEFER)
+ dev_info(dev, "IRQ not populated, err = %d\n",
+ chips->irqs[i]);
return chips->irqs[i];
}
}
--
2.17.1

2019-07-08 17:11:28

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: davinci: silence error prints in case of EPROBE_DEFER

pon., 8 lip 2019 o 10:48 Keerthy <[email protected]> napisał(a):
>
> Silence error prints in case of EPROBE_DEFER. This avoids
> multiple/duplicate defer prints during boot.
>
> Signed-off-by: Keerthy <[email protected]>
> ---
> drivers/gpio/gpio-davinci.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index fc494a84a29d..e0b025689625 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -238,8 +238,9 @@ static int davinci_gpio_probe(struct platform_device *pdev)
> for (i = 0; i < nirq; i++) {
> chips->irqs[i] = platform_get_irq(pdev, i);
> if (chips->irqs[i] < 0) {
> - dev_info(dev, "IRQ not populated, err = %d\n",
> - chips->irqs[i]);
> + if (chips->irqs[i] != -EPROBE_DEFER)
> + dev_info(dev, "IRQ not populated, err = %d\n",
> + chips->irqs[i]);
> return chips->irqs[i];
> }
> }
> --
> 2.17.1
>

Applied to fixes, thanks.

Bart