2019-07-08 17:37:53

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] btrfs: add back libcrc32c Kconfig dependency

While part of btrfs now uses the crypto shash interfaces
for crc32c, we still get a build time dependency in other
places:

fs/btrfs/super.o: In function `btrfs_mount_root':
super.c:(.text+0xc0d4): undefined reference to `crc32c_impl'
fs/btrfs/super.o: In function `btrfs_print_mod_info':
super.c:(.init.text+0x3e28): undefined reference to `crc32c_impl'
fs/btrfs/extent-tree.o: In function `lookup_inline_extent_backref':
extent-tree.c:(.text+0x17750): undefined reference to `crc32c'
fs/btrfs/extent-tree.o:extent-tree.c:(.text+0x177f4): more undefined references to `crc32c' follow

Change Kconfig to depend on both.

Fixes: d5178578bcd4 ("btrfs: directly call into crypto framework for checksumming")
Signed-off-by: Arnd Bergmann <[email protected]>
---
fs/btrfs/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 2521a24f74be..aa7453d44e59 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -3,6 +3,7 @@
config BTRFS_FS
tristate "Btrfs filesystem support"
select CRYPTO
+ select LIBCRC32C
select CRYPTO_CRC32C
select CRYPTO_SHA256
select ZLIB_INFLATE
--
2.20.0


2019-07-08 17:55:55

by Johannes Thumshirn

[permalink] [raw]
Subject: Re: [PATCH] btrfs: add back libcrc32c Kconfig dependency


This is already queued:
https://lore.kernel.org/linux-btrfs/[email protected]/T/#t


--
Johannes Thumshirn SUSE Labs Filesystems
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850