2019-07-09 21:48:41

by Nathan Chancellor

[permalink] [raw]
Subject: [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe

clang warns:

drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret'
[-Wunused-variable]
int ret;
^
1 warning generated.

It's unused now, remove it.

Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
Link: https://github.com/ClangBuiltLinux/linux/issues/591
Reported-by: kernelci.org bot <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
---
drivers/watchdog/digicolor_wdt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
index 33cda95bd238..073d37867f47 100644
--- a/drivers/watchdog/digicolor_wdt.c
+++ b/drivers/watchdog/digicolor_wdt.c
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct dc_wdt *wdt;
- int ret;

wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
if (!wdt)
--
2.22.0


2019-07-18 16:42:06

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe

On Tue, Jul 09, 2019 at 01:34:09PM -0700, Nathan Chancellor wrote:
> clang warns:
>
> drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret'
> [-Wunused-variable]
> int ret;
> ^
> 1 warning generated.
>
> It's unused now, remove it.
>
> Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
> Link: https://github.com/ClangBuiltLinux/linux/issues/591
> Reported-by: kernelci.org bot <[email protected]>
> Signed-off-by: Nathan Chancellor <[email protected]>

Oops, sorry for missing this. I wonder why buildbot neither did find
it... Anyway:

Reviewed-by: Wolfram Sang <[email protected]>


Attachments:
(No filename) (704.00 B)
signature.asc (849.00 B)
Download all attachments