2019-07-06 20:33:05

by Rob Clark

Subject: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs

From: Rob Clark <[email protected]>

This should be more future-proof if we ever encounter a device with two
of these bridges.

Suggested-by: Laurent Pinchart <[email protected]>
Signed-off-by: Rob Clark <[email protected]>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index c8fb45e7b06d..9f4ff88d4a10 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);

static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata)
{
- pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL);
+ pdata->debugfs = debugfs_create_dir(dev_name(pdata->dev), NULL);

debugfs_create_file("status", 0600, pdata->debugfs, pdata,
&status_fops);
--
2.20.1

2019-07-11 16:45:23

by Bjorn Andersson

Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs

On Sat 06 Jul 13:31 PDT 2019, Rob Clark wrote:

> From: Rob Clark <[email protected]>
>
> This should be more future-proof if we ever encounter a device with two
> of these bridges.
>
> Suggested-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Rob Clark <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index c8fb45e7b06d..9f4ff88d4a10 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);
>
> static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata)
> {
> - pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL);
> + pdata->debugfs = debugfs_create_dir(dev_name(pdata->dev), NULL);
>
> debugfs_create_file("status", 0600, pdata->debugfs, pdata,
> &status_fops);
> --
> 2.20.1
>

2019-07-11 16:50:33

by Laurent Pinchart

Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs

Hi Rob,

Thank you for the patch.

On Sat, Jul 06, 2019 at 01:31:02PM -0700, Rob Clark wrote:
> From: Rob Clark <[email protected]>
>
> This should be more future-proof if we ever encounter a device with two
> of these bridges.
>
> Suggested-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Rob Clark <[email protected]>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index c8fb45e7b06d..9f4ff88d4a10 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);
>
> static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata)
> {
> - pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL);
> + pdata->debugfs = debugfs_create_dir(dev_name(pdata->dev), NULL);

That should work, but won't it become quite confusing for users ? I
wonder if the directory name shouldn't be prefixed with the driver name.
Something like "ti_sn65dsi86:%s", dev_name(pdata->dev).

> debugfs_create_file("status", 0600, pdata->debugfs, pdata,
> &status_fops);

--
Regards,

Laurent Pinchart

2019-07-11 18:20:53

by Rob Clark

Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs

On Thu, Jul 11, 2019 at 9:49 AM Laurent Pinchart
<[email protected]> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Sat, Jul 06, 2019 at 01:31:02PM -0700, Rob Clark wrote:
> > From: Rob Clark <[email protected]>
> >
> > This should be more future-proof if we ever encounter a device with two
> > of these bridges.
> >
> > Suggested-by: Laurent Pinchart <[email protected]>
> > Signed-off-by: Rob Clark <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > index c8fb45e7b06d..9f4ff88d4a10 100644
> > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > @@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);
> >
> > static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata)
> > {
> > - pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL);
> > + pdata->debugfs = debugfs_create_dir(dev_name(pdata->dev), NULL);
>
> That should work, but won't it become quite confusing for users ? I
> wonder if the directory name shouldn't be prefixed with the driver name.
> Something like "ti_sn65dsi86:%s", dev_name(pdata->dev).

*maybe*, if they are badly named in dt? In the end the target
audience is really to help developers and people bringing up a new
board, so maybe my way encourages them to use sensible names in dt ;-)

BR,
-R


>
> > debugfs_create_file("status", 0600, pdata->debugfs, pdata,
> > &status_fops);
>
> --
> Regards,
>
> Laurent Pinchart

2019-07-16 07:56:24

by Andrzej Hajda

Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs

On 06.07.2019 22:31, Rob Clark wrote:
> From: Rob Clark <[email protected]>
>
> This should be more future-proof if we ever encounter a device with two
> of these bridges.
>
> Suggested-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Rob Clark <[email protected]>

Queued to drm-misc-next.


Regards

Andrzej