2019-07-15 12:48:24

by Lukasz Luba

Subject: [PATCH v1 43/50] ARM: dts: exynos: add bus_isp in Exynos5422

Add bus_isp which changes ACLK400_ISP clock speed according to the bus
documentation in the documentation. The bus_isp OPP table has been
aligned to the new parent rate. This patch sets the proper parent and
picks the init frequency before the devfreq governor starts working.
It sets also parent rate (DPLL to 1200MHz).

Signed-off-by: Lukasz Luba <[email protected]>
---
arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
index 990fe03fce75..852cb3dd495d 100644
--- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
@@ -166,6 +166,18 @@
status = "okay";
};

+&bus_isp {
+ devfreq = <&bus_wcore>;
+ assigned-clocks = <&clock CLK_MOUT_ACLK400_ISP>,
+ <&clock CLK_MOUT_SW_ACLK400_ISP>,
+ <&clock CLK_DOUT_ACLK400_ISP>,
+ <&clock CLK_FOUT_DPLL>;
+ assigned-clock-parents = <&clock CLK_MOUT_SCLK_DPLL>,
+ <&clock CLK_DOUT_ACLK400_ISP>;
+ assigned-clock-rates = <0>, <0>, <400000000>, <1200000000>;
+ status = "okay";
+};
+
&cpu0 {
cpu-supply = <&buck6_reg>;
};
--
2.17.1

2019-07-17 10:03:45

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 43/50] ARM: dts: exynos: add bus_isp in Exynos5422

On Mon, 15 Jul 2019 at 14:45, Lukasz Luba <[email protected]> wrote:
>
> Add bus_isp which changes ACLK400_ISP clock speed according to the bus
> documentation in the documentation. The bus_isp OPP table has been
> aligned to the new parent rate.

Title and msg needs fixing.

Please squash it with patch 18.

Best regards,
Krzysztof

> This patch sets the proper parent and
> picks the init frequency before the devfreq governor starts working.
> It sets also parent rate (DPLL to 1200MHz).
>
> Signed-off-by: Lukasz Luba <[email protected]>
> ---
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> index 990fe03fce75..852cb3dd495d 100644
> --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> @@ -166,6 +166,18 @@
> status = "okay";
> };
>
> +&bus_isp {
> + devfreq = <&bus_wcore>;
> + assigned-clocks = <&clock CLK_MOUT_ACLK400_ISP>,
> + <&clock CLK_MOUT_SW_ACLK400_ISP>,
> + <&clock CLK_DOUT_ACLK400_ISP>,
> + <&clock CLK_FOUT_DPLL>;
> + assigned-clock-parents = <&clock CLK_MOUT_SCLK_DPLL>,
> + <&clock CLK_DOUT_ACLK400_ISP>;
> + assigned-clock-rates = <0>, <0>, <400000000>, <1200000000>;
> + status = "okay";
> +};
> +
> &cpu0 {
> cpu-supply = <&buck6_reg>;
> };
> --
> 2.17.1
>

2019-07-17 10:14:30

by Lukasz Luba

Subject: Re: [PATCH v1 43/50] ARM: dts: exynos: add bus_isp in Exynos5422

On 7/17/19 12:02 PM, Krzysztof Kozlowski wrote:
> On Mon, 15 Jul 2019 at 14:45, Lukasz Luba <[email protected]> wrote:
>>
>> Add bus_isp which changes ACLK400_ISP clock speed according to the bus
>> documentation in the documentation. The bus_isp OPP table has been
>> aligned to the new parent rate.
>
> Title and msg needs fixing.
>
> Please squash it with patch 18.
You are right, it needs to be squashed. As I mentioned earlier Barek
suggested offline to make 'atomic modifications' of OPPs and PLL/clocks
rates for all affected children in the clock tree.

Regards,
Lukasz
>
> Best regards,
> Krzysztof
>
>> This patch sets the proper parent and
>> picks the init frequency before the devfreq governor starts working.
>> It sets also parent rate (DPLL to 1200MHz).
>>
>> Signed-off-by: Lukasz Luba <[email protected]>
>> ---
>> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
>> index 990fe03fce75..852cb3dd495d 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
>> @@ -166,6 +166,18 @@
>> status = "okay";
>> };
>>
>> +&bus_isp {
>> + devfreq = <&bus_wcore>;
>> + assigned-clocks = <&clock CLK_MOUT_ACLK400_ISP>,
>> + <&clock CLK_MOUT_SW_ACLK400_ISP>,
>> + <&clock CLK_DOUT_ACLK400_ISP>,
>> + <&clock CLK_FOUT_DPLL>;
>> + assigned-clock-parents = <&clock CLK_MOUT_SCLK_DPLL>,
>> + <&clock CLK_DOUT_ACLK400_ISP>;
>> + assigned-clock-rates = <0>, <0>, <400000000>, <1200000000>;
>> + status = "okay";
>> +};
>> +
>> &cpu0 {
>> cpu-supply = <&buck6_reg>;
>> };
>> --
>> 2.17.1
>>
>
>