2019-07-16 17:37:58

by Hariprasad Kelam

Subject: [PATCH] infiniband: hw: qedr: Remove Unneeded variable rc

fix below issue reported by coccicheck
drivers/infiniband/hw/qedr/verbs.c:2454:5-7: Unneeded variable: "rc".
Return "0" on line 2499

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/infiniband/hw/qedr/verbs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
index 27d90a84..0c6a4bc 100644
--- a/drivers/infiniband/hw/qedr/verbs.c
+++ b/drivers/infiniband/hw/qedr/verbs.c
@@ -2451,7 +2451,6 @@ int qedr_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata)
struct qedr_dev *dev = qp->dev;
struct ib_qp_attr attr;
int attr_mask = 0;
- int rc = 0;

DP_DEBUG(dev, QEDR_MSG_QP, "destroy qp: destroying %p, qp type=%d\n",
qp, qp->qp_type);
@@ -2496,7 +2495,7 @@ int qedr_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata)
xa_erase_irq(&dev->qps, qp->qp_id);
kfree(qp);
}
- return rc;
+ return 0;
}

int qedr_create_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr, u32 flags,
--
2.7.4

2019-07-17 06:12:53

by Michal Kalderon

Subject: RE: [PATCH] infiniband: hw: qedr: Remove Unneeded variable rc

> From: [email protected] <linux-rdma-
> [email protected]> On Behalf Of Hariprasad Kelam
>
> fix below issue reported by coccicheck
> drivers/infiniband/hw/qedr/verbs.c:2454:5-7: Unneeded variable: "rc".
> Return "0" on line 2499
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
> ---
> drivers/infiniband/hw/qedr/verbs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qedr/verbs.c
> b/drivers/infiniband/hw/qedr/verbs.c
> index 27d90a84..0c6a4bc 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -2451,7 +2451,6 @@ int qedr_destroy_qp(struct ib_qp *ibqp, struct
> ib_udata *udata)
> struct qedr_dev *dev = qp->dev;
> struct ib_qp_attr attr;
> int attr_mask = 0;
> - int rc = 0;
>
> DP_DEBUG(dev, QEDR_MSG_QP, "destroy qp: destroying %p, qp
> type=%d\n",
> qp, qp->qp_type);
> @@ -2496,7 +2495,7 @@ int qedr_destroy_qp(struct ib_qp *ibqp, struct
> ib_udata *udata)
> xa_erase_irq(&dev->qps, qp->qp_id);
> kfree(qp);
> }
> - return rc;
> + return 0;
> }
>
> int qedr_create_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr, u32 flags,
> --
> 2.7.4

Thanks,?

Acked-by: Michal Kalderon?<[email protected]>

2019-07-25 18:10:58

by Jason Gunthorpe

Subject: Re: [PATCH] infiniband: hw: qedr: Remove Unneeded variable rc

On Tue, Jul 16, 2019 at 11:07:12PM +0530, Hariprasad Kelam wrote:
> fix below issue reported by coccicheck
> drivers/infiniband/hw/qedr/verbs.c:2454:5-7: Unneeded variable: "rc".
> Return "0" on line 2499
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
> ---
> drivers/infiniband/hw/qedr/verbs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-next, thanks

Jason