2019-07-18 10:26:56

by Daniel Baluta

[permalink] [raw]
Subject: [PATCH v2 0/3] Add power domain range for MU13 side b / IRQSTR_DSP

This patch adds power domain range for MU13 side b and irqsteer in
preparation for adding support for DSP <-> AP IPC communication.

Changes since v1:
- fixed typo in patch 1/3 commit message
- enhance commit message for patch 2/3 as per Aisheng's comments
- only add PD range for mu 13 side B

Daniel Baluta (3):
firmware: imx: scu-pd: Rename mu PD range to mu_a
firmware: imx: scu-pd: Add mu13 b side PD range
firmware: imx: scu-pd: Add IRQSTR_DSP PD range

drivers/firmware/imx/scu-pd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

--
2.17.1


2019-07-18 10:27:25

by Daniel Baluta

[permalink] [raw]
Subject: [PATCH v2 2/3] firmware: imx: scu-pd: Add mu13 b side PD range

LSIO subsystem contains 14 MU instances.

5 MUs to communicate between AP <-> SCU
- side-A PD range managed by AP
- side-B PD range managed by SCU

9 MUs to communicate between all cores (AP/M4/DSP).
- side-A PD range managed by core-A (AP/M4/DSP)
- side-B PD range managed by core-B (AP/M4/DSP).

Communication between AP <-> DSP is done through the
assigned MU number 13.

So, we power up side-A by the AP and we decide to
power up side-B also from AP. This is because powering
it up from DSP would be painful.

Powering up side B from DSP would require the DSP to
communicate with SCU and to keep things simple we don't
want that now.

Signed-off-by: Daniel Baluta <[email protected]>
---
drivers/firmware/imx/scu-pd.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index 950d30238186..eb9700b66a76 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -93,6 +93,7 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "kpp", IMX_SC_R_KPP, 1, false, 0 },
{ "fspi", IMX_SC_R_FSPI_0, 2, true, 0 },
{ "mu_a", IMX_SC_R_MU_0A, 14, true, 0 },
+ { "mu_b", IMX_SC_R_MU_13B, 1, true, 13 },

/* CONN SS */
{ "usb", IMX_SC_R_USB_0, 2, true, 0 },
--
2.17.1

2019-07-18 11:57:49

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH v2 2/3] firmware: imx: scu-pd: Add mu13 b side PD range

> From: Daniel Baluta <[email protected]>
> Sent: Thursday, July 18, 2019 6:25 PM
>
> LSIO subsystem contains 14 MU instances.
>
> 5 MUs to communicate between AP <-> SCU
> - side-A PD range managed by AP
> - side-B PD range managed by SCU
>
> 9 MUs to communicate between all cores (AP/M4/DSP).
> - side-A PD range managed by core-A (AP/M4/DSP)
> - side-B PD range managed by core-B (AP/M4/DSP).
>
> Communication between AP <-> DSP is done through the assigned MU number
> 13.
>
> So, we power up side-A by the AP and we decide to power up side-B also from
> AP. This is because powering it up from DSP would be painful.
>
> Powering up side B from DSP would require the DSP to communicate with SCU
> and to keep things simple we don't want that now.
>
> Signed-off-by: Daniel Baluta <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

2019-07-23 17:28:26

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] Add power domain range for MU13 side b / IRQSTR_DSP

On Thu, Jul 18, 2019 at 01:25:16PM +0300, Daniel Baluta wrote:
> This patch adds power domain range for MU13 side b and irqsteer in
> preparation for adding support for DSP <-> AP IPC communication.
>
> Changes since v1:
> - fixed typo in patch 1/3 commit message
> - enhance commit message for patch 2/3 as per Aisheng's comments
> - only add PD range for mu 13 side B
>
> Daniel Baluta (3):
> firmware: imx: scu-pd: Rename mu PD range to mu_a
> firmware: imx: scu-pd: Add mu13 b side PD range
> firmware: imx: scu-pd: Add IRQSTR_DSP PD range

Applied all, thanks.