2019-06-09 19:11:13

by Jacek Anaszewski

[permalink] [raw]
Subject: [PATCH v5 26/26] leds: Document standard LED functions

Add a documentation for standard LED functions with regard
to differences in meaning between cases when devicename section
of LED name is present or not.

Signed-off-by: Jacek Anaszewski <[email protected]>
---
Documentation/leds/led-functions.txt | 223 +++++++++++++++++++++++++++++++++++
Documentation/leds/leds-class.txt | 3 +
2 files changed, 226 insertions(+)
create mode 100644 Documentation/leds/led-functions.txt

diff --git a/Documentation/leds/led-functions.txt b/Documentation/leds/led-functions.txt
new file mode 100644
index 000000000000..003b6b6271d1
--- /dev/null
+++ b/Documentation/leds/led-functions.txt
@@ -0,0 +1,223 @@
+This file presents standardized LED functions and their meaning.
+
+Each LED function is described using below template:
+
+- LED function name
+ NDEV : <function meaning when LED devicename section is absent>
+ DEV : <function meaning when LED devicename section is present>
+ DEVICENAME : <expected LED devicename for DEV case>
+ TRIGGER: <matching LED trigger>
+
+/* LED functions with corresponding trigger support */
+
+- activity
+ NDEV : system activity
+ DEV : n/a
+ TRIGGER : "activity"
+
+- backlight
+ NDEV : n/a
+ DEV : backlight of a frame buffer device
+ DEVICENAME : associated frame buffer device, e.g. fb0
+ TRIGGER: "backlight"
+
+- capslock
+ NDEV : n/a
+ DEV : keyboard capslock state related to the specified input device
+ DEVICENAME : associated input device, e.g. input1
+ TRIGGER : "kbd-capslock"
+
+- disk
+ NDEV : rw activity on any disk in the system
+ DEV : rw activity on specified disk
+ DEVICENAME : associated disk, e.g.: hda, sdb
+ TRIGGER : "disk-activity", applies only to NDEV case
+
+- disk-read
+ NDEV : read activity on any disk in the system
+ DEV : read activity on specified disk
+ DEVICENAME : associted disk, e.g.: hda, sdb
+ TRIGGER : "disk-read", applies only to NDEV case
+
+- disk-write
+ NDEV : write activity on any disk in the system
+ DEV : write activity on specified disk
+ DEVICENAME : associated disk, .e.g" hda, sdb
+ TRIGGER : "disk-write", applies only to NDEV case
+
+- flash
+ NDEV : flash LED (if there is single available on the platform)
+ DEV : flash LED related to the specified video device
+ DEVICENAME : associated video device, e.g. v4l2-subdev3
+ TRIGGER : "flash"; this LED can be also controlled by v4l2-flash framework
+
+- flash-front
+ NDEV : n/a
+ DEV : front flash LED related to the specified video device
+ DEVICENAME : associated video device, e.g. v4l2-subdev3
+ TRIGGER : "flash"; this LED can be also controlled by v4l2-flash framework
+
+- flash-rear
+ NDEV : n/a
+ DEV : rear flash LED related to the specified video device
+ DEVICENAME : associated video device, e.g. v4l2-subdev3
+ TRIGGER : "flash"; this LED can be also controlled by v4l2-flash framework
+
+- heartbeat
+ NDEV : cpu load average expressed as heartbeat-fashion blink frequency
+ DEV : n/a
+ TRIGGER : "heartbeat"
+
+- lan
+ NDEV : n/a
+ DEV : network traffic on selected network device
+ DEVICENAME : associated phy, e.g. phy1
+ TRIGGER : "netdev"
+
+- micmute
+ NDEV : plaform microphone input mute state
+ DEV : mute state of a microphone belonging to the specified device
+ DEVICENAME : associated audio device
+ TRIGGER : "audio-micmute"
+
+- mtd
+ NDEV : rw actvity on any mtd device in the system
+ DEV : rw actvity on specified mtd device
+ DEVICENAME : associated mtd device, e.g mtdN
+ TRIGGER : "mtd"
+
+- mute
+ NDEV : platform audio output mute state
+ DEV : mute state of specified audio device output
+ DEVICENAME : associated audio device
+ TRIGGER : "audio-mute"
+
+- numlock
+ NDEV : n/a
+ DEV : keyboard numlock state related to the specified input device
+ DEVICENAME : associated input device, e.g. input1
+ TRIGGER : "kbd-numlock"
+
+- panic
+ NDEV : signals kernel panic
+ DEV : n/a
+ TRIGGER : "panic"
+
+- scrolllock
+ NDEV : n/a
+ DEV : keyboard scrollock state related to the specified input device
+ DEVICENAME : associated input device, e.g. input1
+ TRIGGER : "kbd-scrolllock"
+
+- torch
+ NDEV : torch LED (if there is single available on the platform)
+ DEV : torch LED related to the specified video device
+ DEVICENAME : associated video device, e.g. video1, v4l2-subdev3
+ TRIGGER : "torch"; this LED can be also controlled by v4l2-flash framework
+
+- usb
+ NDEV : activity on any USB port
+ DEV : activity on a specified USB port
+ DEVICENAME: associated USB device identifier
+ TRIGGER : "usbport"
+
+/* LED functions without corresponding trigger support */
+
+- alarm
+ NDEV : system wide alarm
+ DEV : n/a
+
+- bluetooth
+ NDEV : activity on platform bluetooth adapter
+ DEV : activity on bluetooth adapter related to the specified device
+ DEVICENAME : associated device
+
+- boot
+ NDEV : when lit indicates system boot
+ DEV : n/a
+
+- charging
+ NDEV : battery charging status
+ DEV : n/a
+
+- debug
+ NDEV : signals if device runs in debug mode
+ DEV : n/a
+
+- disk-err
+ NDEV : failure on any disk in the system
+ DEV : failure on specified disk
+ DEVICENAME : associted disk, e.g.: hda, sdb
+
+- fault
+ NDEV : general system fault
+ DEV : fault on specified system device
+ DEVICENAME : related device name
+
+- indicator
+ NDEV : signals if platform camera sensor is active
+ DEV : signals if camera sensor related to the specified video device is active
+ DEVICENAME : associated video device, e.g.: v4l2-subdev3
+
+- kbd_backlight
+ NDEV : platform keyboard backlight state
+ DEV : backlight state related to the specified device
+ DEVICENAME : associated device, e.g. input1
+
+- mail
+ NDEV : signals a new massage in mailbox
+ DEV : n/a
+
+- programming
+ NDEV : platform firmware update is in progress
+ DEV : n/a
+
+- power
+ NDEV : power plug presence indicator
+ DEV : n/a
+
+- rx
+ NDEV : n/a
+ DEV : activity on rx line of serial port related to the specified tty device
+ DEVICENAME: associated tty device, e.g.: tty1, ttyUSB2
+
+- sd
+ NDEV : n/a
+ DEV : activity on sd card related to the specified device
+ DEVICENAME: associated disk, e.g. sdb
+
+- sleep
+ NDEV : signals any variant of system hibernation or suspend state
+ DEV : n/a
+
+- standby
+ NDEV : device standby status
+ DEV : n/a
+
+- status
+ NDEV : system wide status LED
+ DEV : n/a
+
+- system
+ NDEV : system is fully operating
+ DEV : n/a
+
+- tx
+ NDEV : n/a
+ DEV : activity on tx line of serial port related to the specified tty device
+ DEVICENAME: associated tty device, e.g.: tty1, ttyUSB2
+
+- wan
+ NDEV : activity on any WAN device
+ DEV : activity on a specified WAN device
+ DEVICENAME: associated WAN device identifier
+
+- wlan
+ NDEV : activity on any wlan device
+ DEV : activity on a specified wlan device
+ DEVICENAME: associated wlan device identifier
+
+- wps
+ NDEV : n/a
+ DEV : wps functionality activation state related to the specified device
+ DEVICENAME : associated device name
diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt
index e7316e37b57d..30684db9dfca 100644
--- a/Documentation/leds/leds-class.txt
+++ b/Documentation/leds/leds-class.txt
@@ -62,6 +62,9 @@ function: one of the LED_FUNCTION* definitions from the header
If required color or function is missing, please submit a patch
to [email protected], adding required entries.

+The exact meaning of LED function name depends on whether it has devicename
+section filled or left blank. See Documentation/leds/led-functions.txt.
+
It is possible that more than one LED with the same color and function will
be required for given platform, differing only with an ordinal number.
In this case it is preferable to just concatenate the predefined LED_FUNCTION*
--
2.11.0


2019-07-18 11:04:40

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH v5 26/26] leds: Document standard LED functions

Hi!

> Add a documentation for standard LED functions with regard
> to differences in meaning between cases when devicename section
> of LED name is present or not.
>
> Signed-off-by: Jacek Anaszewski <[email protected]>
> ---
> Documentation/leds/led-functions.txt | 223 +++++++++++++++++++++++++++++++++++
> Documentation/leds/leds-class.txt | 3 +
> 2 files changed, 226 insertions(+)
> create mode 100644 Documentation/leds/led-functions.txt
>
> diff --git a/Documentation/leds/led-functions.txt b/Documentation/leds/led-functions.txt
> new file mode 100644
> index 000000000000..003b6b6271d1
> --- /dev/null
> +++ b/Documentation/leds/led-functions.txt
> @@ -0,0 +1,223 @@
> +This file presents standardized LED functions and their meaning.
> +
> +Each LED function is described using below template:
> +
> +- LED function name
> + NDEV : <function meaning when LED devicename section is absent>
> + DEV : <function meaning when LED devicename section is present>
> + DEVICENAME : <expected LED devicename for DEV case>
> + TRIGGER: <matching LED trigger>
> +
> +/* LED functions with corresponding trigger support */
> +
> +- activity
> + NDEV : system activity
> + DEV : n/a
> + TRIGGER : "activity"
> +
> +- backlight
> + NDEV : n/a
> + DEV : backlight of a frame buffer device
> + DEVICENAME : associated frame buffer device, e.g. fb0
> + TRIGGER: "backlight"

ndev: if there's single one on the platform?

> +- capslock
> + NDEV : n/a
> + DEV : keyboard capslock state related to the specified input device
> + DEVICENAME : associated input device, e.g. input1
> + TRIGGER : "kbd-capslock"
> +

> +- disk
> + NDEV : rw activity on any disk in the system
> + DEV : rw activity on specified disk
> + DEVICENAME : associated disk, e.g.: hda, sdb
> + TRIGGER : "disk-activity", applies only to NDEV case

I'd sort this file according to the places where these leds are
usually are present, to make it simpler for user to find the
labels. capslock should go near scrollock etc.

Plus I guess explanation in which systems such LED is found would be
good.

Global "disk" LED is very common on the PCs, and we should make sure
such LEDs have consistent labeling everywhere.

> +- disk-read
> + NDEV : read activity on any disk in the system
> + DEV : read activity on specified disk
> + DEVICENAME : associted disk, e.g.: hda, sdb
> + TRIGGER : "disk-read", applies only to NDEV case
> +
> +- disk-write
> + NDEV : write activity on any disk in the system
> + DEV : write activity on specified disk
> + DEVICENAME : associated disk, .e.g" hda, sdb
> + TRIGGER : "disk-write", applies only to NDEV case

I don't see separated read/write LEDs very often. To keep the file
size down, I'd list is at "disk-read, disk-write".

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Attachments:
(No filename) (3.01 kB)
signature.asc (188.00 B)
Digital signature
Download all attachments

2019-07-18 13:33:42

by Jacek Anaszewski

[permalink] [raw]
Subject: Re: [PATCH v5 26/26] leds: Document standard LED functions

Hi Pavel,

Thanks for the review.

On 7/18/19 1:03 PM, Pavel Machek wrote:
> Hi!
>
>> Add a documentation for standard LED functions with regard
>> to differences in meaning between cases when devicename section
>> of LED name is present or not.
>>
>> Signed-off-by: Jacek Anaszewski <[email protected]>
>> ---
>> Documentation/leds/led-functions.txt | 223 +++++++++++++++++++++++++++++++++++
>> Documentation/leds/leds-class.txt | 3 +
>> 2 files changed, 226 insertions(+)
>> create mode 100644 Documentation/leds/led-functions.txt
>>
>> diff --git a/Documentation/leds/led-functions.txt b/Documentation/leds/led-functions.txt
>> new file mode 100644
>> index 000000000000..003b6b6271d1
>> --- /dev/null
>> +++ b/Documentation/leds/led-functions.txt
>> @@ -0,0 +1,223 @@
>> +This file presents standardized LED functions and their meaning.
>> +
>> +Each LED function is described using below template:
>> +
>> +- LED function name
>> + NDEV : <function meaning when LED devicename section is absent>
>> + DEV : <function meaning when LED devicename section is present>
>> + DEVICENAME : <expected LED devicename for DEV case>
>> + TRIGGER: <matching LED trigger>
>> +
>> +/* LED functions with corresponding trigger support */
>> +
>> +- activity
>> + NDEV : system activity
>> + DEV : n/a
>> + TRIGGER : "activity"
>> +
>> +- backlight
>> + NDEV : n/a
>> + DEV : backlight of a frame buffer device
>> + DEVICENAME : associated frame buffer device, e.g. fb0
>> + TRIGGER: "backlight"
>
> ndev: if there's single one on the platform?

Ack.

>> +- capslock
>> + NDEV : n/a
>> + DEV : keyboard capslock state related to the specified input device
>> + DEVICENAME : associated input device, e.g. input1
>> + TRIGGER : "kbd-capslock"
>> +
>
>> +- disk
>> + NDEV : rw activity on any disk in the system
>> + DEV : rw activity on specified disk
>> + DEVICENAME : associated disk, e.g.: hda, sdb
>> + TRIGGER : "disk-activity", applies only to NDEV case
>
> I'd sort this file according to the places where these leds are
> usually are present, to make it simpler for user to find the
> labels. capslock should go near scrollock etc.
>
> Plus I guess explanation in which systems such LED is found would be
> good.

I need more input on that. No idea what you mean.

> Global "disk" LED is very common on the PCs, and we should make sure
> such LEDs have consistent labeling everywhere.

Could you please be more specific and give some examples of the rework
you propose? Whereas it's clear what you mean regarding keyboard LEDs,
I'm not sure what is your intention in case of "disk".

>> +- disk-read
>> + NDEV : read activity on any disk in the system
>> + DEV : read activity on specified disk
>> + DEVICENAME : associted disk, e.g.: hda, sdb
>> + TRIGGER : "disk-read", applies only to NDEV case
>> +
>> +- disk-write
>> + NDEV : write activity on any disk in the system
>> + DEV : write activity on specified disk
>> + DEVICENAME : associated disk, .e.g" hda, sdb
>> + TRIGGER : "disk-write", applies only to NDEV case
>
> I don't see separated read/write LEDs very often. To keep the file
> size down, I'd list is at "disk-read, disk-write".

Ack.

--
Best regards,
Jacek Anaszewski