2019-07-19 10:10:01

by Wen He

[permalink] [raw]
Subject: [v2 2/3] dt/bindings: display: Add optional property node defined for Mali DP500

Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
This property describe the ARQoS levels of DP500's QoS signaling.

Signed-off-by: Wen He <[email protected]>
---
Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt b/Documentation/devicetree/bindings/display/arm,malidp.txt
index 2f7870983ef1..76a0e7251251 100644
--- a/Documentation/devicetree/bindings/display/arm,malidp.txt
+++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
@@ -37,6 +37,8 @@ Optional properties:
Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
to be used for the framebuffer; if not present, the framebuffer may
be located anywhere in memory.
+ - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
+ levels of DP500's QoS signaling.


Example:
@@ -54,6 +56,7 @@ Example:
clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
clock-names = "pxlclk", "mclk", "aclk", "pclk";
arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
+ arm,malidp-arqos-high-level = <&rqosvalue>;
port {
dp0_output: endpoint {
remote-endpoint = <&tda998x_2_input>;
--
2.17.1


2019-07-19 12:18:33

by Liviu Dudau

[permalink] [raw]
Subject: Re: [v2 2/3] dt/bindings: display: Add optional property node defined for Mali DP500

On Fri, Jul 19, 2019 at 05:58:42PM +0800, Wen He wrote:
> Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
> This property describe the ARQoS levels of DP500's QoS signaling.
>
> Signed-off-by: Wen He <[email protected]>

Acked-by: Liviu Dudau <[email protected]>

Thanks for the patch!

Best regards,
Liviu

> ---
> Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt b/Documentation/devicetree/bindings/display/arm,malidp.txt
> index 2f7870983ef1..76a0e7251251 100644
> --- a/Documentation/devicetree/bindings/display/arm,malidp.txt
> +++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
> @@ -37,6 +37,8 @@ Optional properties:
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
> to be used for the framebuffer; if not present, the framebuffer may
> be located anywhere in memory.
> + - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
> + levels of DP500's QoS signaling.
>
>
> Example:
> @@ -54,6 +56,7 @@ Example:
> clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
> clock-names = "pxlclk", "mclk", "aclk", "pclk";
> arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> + arm,malidp-arqos-high-level = <&rqosvalue>;
> port {
> dp0_output: endpoint {
> remote-endpoint = <&tda998x_2_input>;
> --
> 2.17.1
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯

2019-08-12 23:23:28

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [v2 2/3] dt/bindings: display: Add optional property node defined for Mali DP500

On Fri, Jul 19, 2019 at 05:58:42PM +0800, Wen He wrote:
> Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
> This property describe the ARQoS levels of DP500's QoS signaling.
>
> Signed-off-by: Wen He <[email protected]>
> ---
> Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt b/Documentation/devicetree/bindings/display/arm,malidp.txt
> index 2f7870983ef1..76a0e7251251 100644
> --- a/Documentation/devicetree/bindings/display/arm,malidp.txt
> +++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
> @@ -37,6 +37,8 @@ Optional properties:
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
> to be used for the framebuffer; if not present, the framebuffer may
> be located anywhere in memory.
> + - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
> + levels of DP500's QoS signaling.

u32 here, and...

>
>
> Example:
> @@ -54,6 +56,7 @@ Example:
> clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
> clock-names = "pxlclk", "mclk", "aclk", "pclk";
> arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> + arm,malidp-arqos-high-level = <&rqosvalue>;

phandle here?

> port {
> dp0_output: endpoint {
> remote-endpoint = <&tda998x_2_input>;
> --
> 2.17.1
>

2019-08-14 06:37:11

by Wen He

[permalink] [raw]
Subject: RE: [EXT] Re: [v2 2/3] dt/bindings: display: Add optional property node defined for Mali DP500



> -----Original Message-----
> From: Rob Herring <[email protected]>
> Sent: 2019??8??13?? 7:20
> To: Wen He <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Leo Li
> <[email protected]>
> Subject: [EXT] Re: [v2 2/3] dt/bindings: display: Add optional property node
> defined for Mali DP500
>
>
> On Fri, Jul 19, 2019 at 05:58:42PM +0800, Wen He wrote:
> > Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
> > This property describe the ARQoS levels of DP500's QoS signaling.
> >
> > Signed-off-by: Wen He <[email protected]>
> > ---
> > Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt
> b/Documentation/devicetree/bindings/display/arm,malidp.txt
> > index 2f7870983ef1..76a0e7251251 100644
> > --- a/Documentation/devicetree/bindings/display/arm,malidp.txt
> > +++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
> > @@ -37,6 +37,8 @@ Optional properties:
> >
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
> > to be used for the framebuffer; if not present, the framebuffer may
> > be located anywhere in memory.
> > + - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
> > + levels of DP500's QoS signaling.
>
> u32 here, and...

Hi Rob,

Sorry, should be written as" phandle to a node describing the AQRoS levels of DP500's QoS signaling"..
Is that ok?

Best Regards,
Wen

>
> >
> >
> > Example:
> > @@ -54,6 +56,7 @@ Example:
> > clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>,
> <&fpgaosc1>;
> > clock-names = "pxlclk", "mclk", "aclk", "pclk";
> > arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> > + arm,malidp-arqos-high-level = <&rqosvalue>;
>
> phandle here?
>
> > port {
> > dp0_output: endpoint {
> > remote-endpoint = <&tda998x_2_input>;
> > --
> > 2.17.1
> >