2019-07-09 14:00:22

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] drm/komeda: remove set but not used variable 'old'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/arm/display/komeda/komeda_plane.c:
In function komeda_plane_atomic_duplicate_state:
drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35:
warning: variable old set but not used [-Wunused-but-set-variable

It is not used since commit 990dee3aa456 ("drm/komeda:
Computing image enhancer internally")

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index c095af1..c1381ac 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
@@ -158,8 +158,6 @@ static void komeda_plane_reset(struct drm_plane *plane)
static struct drm_plane_state *
komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
{
- struct komeda_plane_state *new, *old;
-
if (WARN_ON(!plane->state))
return NULL;

@@ -169,8 +167,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane *plane)

__drm_atomic_helper_plane_duplicate_state(plane, &new->base);

- old = to_kplane_st(plane->state);
-
return &new->base;
}

--
2.7.4



2019-07-18 18:52:57

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH -next] drm/komeda: remove set but not used variable 'old'

On Tue, Jul 09, 2019 at 09:58:08PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:
> In function komeda_plane_atomic_duplicate_state:
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35:
> warning: variable old set but not used [-Wunused-but-set-variable
>
> It is not used since commit 990dee3aa456 ("drm/komeda:
> Computing image enhancer internally")
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Queued for 5.3, thanks for your patch.
-Daniel

> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index c095af1..c1381ac 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -158,8 +158,6 @@ static void komeda_plane_reset(struct drm_plane *plane)
> static struct drm_plane_state *
> komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
> {
> - struct komeda_plane_state *new, *old;
> -
> if (WARN_ON(!plane->state))
> return NULL;
>
> @@ -169,8 +167,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
>
> __drm_atomic_helper_plane_duplicate_state(plane, &new->base);
>
> - old = to_kplane_st(plane->state);
> -
> return &new->base;
> }
>
> --
> 2.7.4
>
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2019-07-19 13:35:15

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH -next] drm/komeda: remove set but not used variable 'old'

On Thu, Jul 18, 2019 at 08:51:50PM +0200, Daniel Vetter wrote:
> On Tue, Jul 09, 2019 at 09:58:08PM +0800, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/gpu/drm/arm/display/komeda/komeda_plane.c:
> > In function komeda_plane_atomic_duplicate_state:
> > drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35:
> > warning: variable old set but not used [-Wunused-but-set-variable
> >
> > It is not used since commit 990dee3aa456 ("drm/komeda:
> > Computing image enhancer internally")
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: YueHaibing <[email protected]>
>
> Queued for 5.3, thanks for your patch.

Correction, this doesn't even compile. Please compile-test patches before
submitting.

Thanks, Daniel

> -Daniel
>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> > index c095af1..c1381ac 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> > @@ -158,8 +158,6 @@ static void komeda_plane_reset(struct drm_plane *plane)
> > static struct drm_plane_state *
> > komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
> > {
> > - struct komeda_plane_state *new, *old;
> > -
> > if (WARN_ON(!plane->state))
> > return NULL;
> >
> > @@ -169,8 +167,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
> >
> > __drm_atomic_helper_plane_duplicate_state(plane, &new->base);
> >
> > - old = to_kplane_st(plane->state);
> > -
> > return &new->base;
> > }
> >
> > --
> > 2.7.4
> >
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2019-07-22 02:03:08

by Yue Haibing

[permalink] [raw]
Subject: Re: [PATCH -next] drm/komeda: remove set but not used variable 'old'

On 2019/7/19 21:04, Daniel Vetter wrote:
> On Thu, Jul 18, 2019 at 08:51:50PM +0200, Daniel Vetter wrote:
>> On Tue, Jul 09, 2019 at 09:58:08PM +0800, YueHaibing wrote:
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:
>>> In function komeda_plane_atomic_duplicate_state:
>>> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35:
>>> warning: variable old set but not used [-Wunused-but-set-variable
>>>
>>> It is not used since commit 990dee3aa456 ("drm/komeda:
>>> Computing image enhancer internally")
>>>
>>> Reported-by: Hulk Robot <[email protected]>
>>> Signed-off-by: YueHaibing <[email protected]>
>>
>> Queued for 5.3, thanks for your patch.
>
> Correction, this doesn't even compile. Please compile-test patches before
> submitting.
>

Oops, sorry for this, I'll be more carefully.

> Thanks, Daniel
>
>> -Daniel
>>
>>> ---
>>> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 ----
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
>>> index c095af1..c1381ac 100644
>>> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
>>> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
>>> @@ -158,8 +158,6 @@ static void komeda_plane_reset(struct drm_plane *plane)
>>> static struct drm_plane_state *
>>> komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
>>> {
>>> - struct komeda_plane_state *new, *old;
>>> -
>>> if (WARN_ON(!plane->state))
>>> return NULL;
>>>
>>> @@ -169,8 +167,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
>>>
>>> __drm_atomic_helper_plane_duplicate_state(plane, &new->base);
>>>
>>> - old = to_kplane_st(plane->state);
>>> -
>>> return &new->base;
>>> }
>>>
>>> --
>>> 2.7.4
>>>
>>>
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> http://blog.ffwll.ch
>

2019-07-22 05:59:10

by Yue Haibing

[permalink] [raw]
Subject: [PATCH v2 -next] drm/komeda: remove set but not used variable 'old'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/arm/display/komeda/komeda_plane.c:
In function komeda_plane_atomic_duplicate_state:
drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35:
warning: variable old set but not used [-Wunused-but-set-variable

It is not used since commit 990dee3aa456 ("drm/komeda:
Computing image enhancer internally")

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
v2: fix compile err
---
drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index c095af1..98e915e 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
@@ -158,7 +158,7 @@ static void komeda_plane_reset(struct drm_plane *plane)
static struct drm_plane_state *
komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
{
- struct komeda_plane_state *new, *old;
+ struct komeda_plane_state *new;

if (WARN_ON(!plane->state))
return NULL;
@@ -169,8 +169,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane *plane)

__drm_atomic_helper_plane_duplicate_state(plane, &new->base);

- old = to_kplane_st(plane->state);
-
return &new->base;
}

--
2.7.4


2019-07-23 18:03:15

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH v2 -next] drm/komeda: remove set but not used variable 'old'

On Mon, Jul 22, 2019 at 01:56:27PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:
> In function komeda_plane_atomic_duplicate_state:
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35:
> warning: variable old set but not used [-Wunused-but-set-variable
>
> It is not used since commit 990dee3aa456 ("drm/komeda:
> Computing image enhancer internally")
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> v2: fix compile err

Ok this one worked, applied.

Thanks, Daniel

> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index c095af1..98e915e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -158,7 +158,7 @@ static void komeda_plane_reset(struct drm_plane *plane)
> static struct drm_plane_state *
> komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
> {
> - struct komeda_plane_state *new, *old;
> + struct komeda_plane_state *new;
>
> if (WARN_ON(!plane->state))
> return NULL;
> @@ -169,8 +169,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
>
> __drm_atomic_helper_plane_duplicate_state(plane, &new->base);
>
> - old = to_kplane_st(plane->state);
> -
> return &new->base;
> }
>
> --
> 2.7.4
>
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch