2019-07-24 06:35:15

by Anson Huang

[permalink] [raw]
Subject: [PATCH] clk: imx: Remove unused function statement

From: Anson Huang <[email protected]>

imx_register_uart_clocks_hws() function is NOT implemented
at all, remove it.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/clk/imx/clk.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h
index 9995f2a..f7a389a 100644
--- a/drivers/clk/imx/clk.h
+++ b/drivers/clk/imx/clk.h
@@ -10,7 +10,6 @@ extern spinlock_t imx_ccm_lock;
void imx_check_clocks(struct clk *clks[], unsigned int count);
void imx_check_clk_hws(struct clk_hw *clks[], unsigned int count);
void imx_register_uart_clocks(struct clk ** const clks[]);
-void imx_register_uart_clocks_hws(struct clk_hw ** const hws[]);
void imx_mmdc_mask_handshake(void __iomem *ccm_base, unsigned int chn);
void imx_unregister_clocks(struct clk *clks[], unsigned int count);

--
2.7.4


2019-07-24 07:06:12

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH] clk: imx: Remove unused function statement

Hello,

On Wed, Jul 24, 2019 at 02:24:35PM +0800, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> imx_register_uart_clocks_hws() function is NOT implemented
> at all, remove it.
>
> Signed-off-by: Anson Huang <[email protected]>

Looks right. This function never existed, the prototype was introduced
in commit dd1a6c0d339b ("clk: imx: clk-busy: Switch to clk_hw based
API") in the 5.3-rc1 cycle.

Acked-by: Uwe Kleine-K?nig <[email protected]>

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |

2019-07-26 08:39:22

by Abel Vesa

[permalink] [raw]
Subject: Re: [PATCH] clk: imx: Remove unused function statement

On 19-07-24 14:24:35, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> imx_register_uart_clocks_hws() function is NOT implemented
> at all, remove it.
>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

> ---
> drivers/clk/imx/clk.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h
> index 9995f2a..f7a389a 100644
> --- a/drivers/clk/imx/clk.h
> +++ b/drivers/clk/imx/clk.h
> @@ -10,7 +10,6 @@ extern spinlock_t imx_ccm_lock;
> void imx_check_clocks(struct clk *clks[], unsigned int count);
> void imx_check_clk_hws(struct clk_hw *clks[], unsigned int count);
> void imx_register_uart_clocks(struct clk ** const clks[]);
> -void imx_register_uart_clocks_hws(struct clk_hw ** const hws[]);
> void imx_mmdc_mask_handshake(void __iomem *ccm_base, unsigned int chn);
> void imx_unregister_clocks(struct clk *clks[], unsigned int count);
>
> --
> 2.7.4
>

2019-08-04 03:39:21

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] clk: imx: Remove unused function statement

On Wed, Jul 24, 2019 at 02:24:35PM +0800, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> imx_register_uart_clocks_hws() function is NOT implemented
> at all, remove it.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied, thanks.