2019-07-24 08:26:30

by Bartosz Golaszewski

Subject: [PATCH v3 5/7] backlight: gpio: remove dev from struct gpio_backlight

From: Bartosz Golaszewski <[email protected]>

This field is unused. Remove it.

Signed-off-by: Bartosz Golaszewski <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/video/backlight/gpio_backlight.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index 01262186fa1e..70882556f047 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -19,9 +19,7 @@
#include <linux/slab.h>

struct gpio_backlight {
- struct device *dev;
struct device *fbdev;
-
struct gpio_desc *gpiod;
int def_value;
};
@@ -69,8 +67,6 @@ static int gpio_backlight_probe(struct platform_device *pdev)
if (gbl == NULL)
return -ENOMEM;

- gbl->dev = &pdev->dev;
-
if (pdata)
gbl->fbdev = pdata->fbdev;

--
2.21.0

2019-07-24 11:14:24

by Daniel Thompson

Subject: Re: [PATCH v3 5/7] backlight: gpio: remove dev from struct gpio_backlight

On Wed, Jul 24, 2019 at 10:25:06AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> This field is unused. Remove it.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>

> ---
> drivers/video/backlight/gpio_backlight.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 01262186fa1e..70882556f047 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -19,9 +19,7 @@
> #include <linux/slab.h>
>
> struct gpio_backlight {
> - struct device *dev;
> struct device *fbdev;
> -
> struct gpio_desc *gpiod;
> int def_value;
> };
> @@ -69,8 +67,6 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> if (gbl == NULL)
> return -ENOMEM;
>
> - gbl->dev = &pdev->dev;
> -
> if (pdata)
> gbl->fbdev = pdata->fbdev;
>
> --
> 2.21.0
>