2019-07-24 08:26:29

by Bartosz Golaszewski

Subject: [PATCH v3 7/7] backlight: gpio: use a helper variable for &pdev->dev

From: Bartosz Golaszewski <[email protected]>

Instead of dereferencing pdev each time, use a helper variable for
the associated device pointer.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/video/backlight/gpio_backlight.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index cd6a75bca9cc..7dc4f90d926b 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -54,29 +54,29 @@ static const struct backlight_ops gpio_backlight_ops = {

static int gpio_backlight_probe(struct platform_device *pdev)
{
- struct gpio_backlight_platform_data *pdata =
- dev_get_platdata(&pdev->dev);
+ struct device *dev = &pdev->dev;
+ struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev);
struct backlight_properties props;
struct backlight_device *bl;
struct gpio_backlight *gbl;
enum gpiod_flags flags;
int ret, def_value;

- gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL);
+ gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
if (gbl == NULL)
return -ENOMEM;

if (pdata)
gbl->fbdev = pdata->fbdev;

- def_value = device_property_read_bool(&pdev->dev, "default-on");
+ def_value = device_property_read_bool(dev, "default-on");
flags = def_value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;

- gbl->gpiod = devm_gpiod_get(&pdev->dev, NULL, flags);
+ gbl->gpiod = devm_gpiod_get(dev, NULL, flags);
if (IS_ERR(gbl->gpiod)) {
ret = PTR_ERR(gbl->gpiod);
if (ret != -EPROBE_DEFER) {
- dev_err(&pdev->dev,
+ dev_err(dev,
"Error: The gpios parameter is missing or invalid.\n");
}
return ret;
@@ -85,11 +85,10 @@ static int gpio_backlight_probe(struct platform_device *pdev)
memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_RAW;
props.max_brightness = 1;
- bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev),
- &pdev->dev, gbl, &gpio_backlight_ops,
- &props);
+ bl = devm_backlight_device_register(dev, dev_name(dev), dev, gbl,
+ &gpio_backlight_ops, &props);
if (IS_ERR(bl)) {
- dev_err(&pdev->dev, "failed to register backlight\n");
+ dev_err(dev, "failed to register backlight\n");
return PTR_ERR(bl);
}

--
2.21.0

2019-07-24 11:16:32

by Daniel Thompson

Subject: Re: [PATCH v3 7/7] backlight: gpio: use a helper variable for &pdev->dev

On Wed, Jul 24, 2019 at 10:25:08AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> Instead of dereferencing pdev each time, use a helper variable for
> the associated device pointer.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>

> ---
> drivers/video/backlight/gpio_backlight.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index cd6a75bca9cc..7dc4f90d926b 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -54,29 +54,29 @@ static const struct backlight_ops gpio_backlight_ops = {
>
> static int gpio_backlight_probe(struct platform_device *pdev)
> {
> - struct gpio_backlight_platform_data *pdata =
> - dev_get_platdata(&pdev->dev);
> + struct device *dev = &pdev->dev;
> + struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev);
> struct backlight_properties props;
> struct backlight_device *bl;
> struct gpio_backlight *gbl;
> enum gpiod_flags flags;
> int ret, def_value;
>
> - gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL);
> + gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
> if (gbl == NULL)
> return -ENOMEM;
>
> if (pdata)
> gbl->fbdev = pdata->fbdev;
>
> - def_value = device_property_read_bool(&pdev->dev, "default-on");
> + def_value = device_property_read_bool(dev, "default-on");
> flags = def_value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
>
> - gbl->gpiod = devm_gpiod_get(&pdev->dev, NULL, flags);
> + gbl->gpiod = devm_gpiod_get(dev, NULL, flags);
> if (IS_ERR(gbl->gpiod)) {
> ret = PTR_ERR(gbl->gpiod);
> if (ret != -EPROBE_DEFER) {
> - dev_err(&pdev->dev,
> + dev_err(dev,
> "Error: The gpios parameter is missing or invalid.\n");
> }
> return ret;
> @@ -85,11 +85,10 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> memset(&props, 0, sizeof(props));
> props.type = BACKLIGHT_RAW;
> props.max_brightness = 1;
> - bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev),
> - &pdev->dev, gbl, &gpio_backlight_ops,
> - &props);
> + bl = devm_backlight_device_register(dev, dev_name(dev), dev, gbl,
> + &gpio_backlight_ops, &props);
> if (IS_ERR(bl)) {
> - dev_err(&pdev->dev, "failed to register backlight\n");
> + dev_err(dev, "failed to register backlight\n");
> return PTR_ERR(bl);
> }
>
> --
> 2.21.0
>

2019-07-24 15:22:13

by Andy Shevchenko

Subject: Re: [PATCH v3 7/7] backlight: gpio: use a helper variable for &pdev->dev

On Wed, Jul 24, 2019 at 10:25:08AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> Instead of dereferencing pdev each time, use a helper variable for
> the associated device pointer.

Reviewed-by: Andy Shevchenko <[email protected]>

>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/video/backlight/gpio_backlight.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index cd6a75bca9cc..7dc4f90d926b 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -54,29 +54,29 @@ static const struct backlight_ops gpio_backlight_ops = {
>
> static int gpio_backlight_probe(struct platform_device *pdev)
> {
> - struct gpio_backlight_platform_data *pdata =
> - dev_get_platdata(&pdev->dev);
> + struct device *dev = &pdev->dev;
> + struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev);
> struct backlight_properties props;
> struct backlight_device *bl;
> struct gpio_backlight *gbl;
> enum gpiod_flags flags;
> int ret, def_value;
>
> - gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL);
> + gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
> if (gbl == NULL)
> return -ENOMEM;
>
> if (pdata)
> gbl->fbdev = pdata->fbdev;
>
> - def_value = device_property_read_bool(&pdev->dev, "default-on");
> + def_value = device_property_read_bool(dev, "default-on");
> flags = def_value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
>
> - gbl->gpiod = devm_gpiod_get(&pdev->dev, NULL, flags);
> + gbl->gpiod = devm_gpiod_get(dev, NULL, flags);
> if (IS_ERR(gbl->gpiod)) {
> ret = PTR_ERR(gbl->gpiod);
> if (ret != -EPROBE_DEFER) {
> - dev_err(&pdev->dev,
> + dev_err(dev,
> "Error: The gpios parameter is missing or invalid.\n");
> }
> return ret;
> @@ -85,11 +85,10 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> memset(&props, 0, sizeof(props));
> props.type = BACKLIGHT_RAW;
> props.max_brightness = 1;
> - bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev),
> - &pdev->dev, gbl, &gpio_backlight_ops,
> - &props);
> + bl = devm_backlight_device_register(dev, dev_name(dev), dev, gbl,
> + &gpio_backlight_ops, &props);
> if (IS_ERR(bl)) {
> - dev_err(&pdev->dev, "failed to register backlight\n");
> + dev_err(dev, "failed to register backlight\n");
> return PTR_ERR(bl);
> }
>
> --
> 2.21.0
>

--
With Best Regards,
Andy Shevchenko