2019-07-25 05:51:53

by Chuhong Yuan

Subject: [PATCH] ALSA: echoaudio: Replace kmalloc + memcpy with kmemdup

Instead of using kmalloc + memcpy, use kmemdup
to simplify the code.

Signed-off-by: Chuhong Yuan <[email protected]>
---
sound/pci/echoaudio/echoaudio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index b612a536a5a1..ca9125726be2 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -2189,11 +2189,10 @@ static int snd_echo_resume(struct device *dev)
u32 pipe_alloc_mask;
int err;

- commpage_bak = kmalloc(sizeof(*commpage), GFP_KERNEL);
+ commpage = chip->comm_page;
+ commpage_bak = kmemdup(commpage, sizeof(*commpage), GFP_KERNEL);
if (commpage_bak == NULL)
return -ENOMEM;
- commpage = chip->comm_page;
- memcpy(commpage_bak, commpage, sizeof(*commpage));

err = init_hw(chip, chip->pci->device, chip->pci->subsystem_device);
if (err < 0) {
--
2.20.1

2019-07-25 18:04:23

by Takashi Iwai

Subject: Re: [PATCH] ALSA: echoaudio: Replace kmalloc + memcpy with kmemdup

On Thu, 25 Jul 2019 04:09:24 +0200,
Chuhong Yuan wrote:
>
> Instead of using kmalloc + memcpy, use kmemdup
> to simplify the code.
>
> Signed-off-by: Chuhong Yuan <[email protected]>

Applied, thanks.


Takashi