2019-07-16 17:30:45

by Hariprasad Kelam

Subject: [PATCH] infiniband: hw: qib: Unneeded variable ret

fix below issue reported by coccicheck
drivers/infiniband/hw/qib/qib_file_ops.c:1792:5-8: Unneeded variable:
"ret". Return "0" on line 1876

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/infiniband/hw/qib/qib_file_ops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_file_ops.c b/drivers/infiniband/hw/qib/qib_file_ops.c
index 27b6e66..b014422 100644
--- a/drivers/infiniband/hw/qib/qib_file_ops.c
+++ b/drivers/infiniband/hw/qib/qib_file_ops.c
@@ -1789,7 +1789,6 @@ static void unlock_expected_tids(struct qib_ctxtdata *rcd)

static int qib_close(struct inode *in, struct file *fp)
{
- int ret = 0;
struct qib_filedata *fd;
struct qib_ctxtdata *rcd;
struct qib_devdata *dd;
@@ -1873,7 +1872,7 @@ static int qib_close(struct inode *in, struct file *fp)

bail:
kfree(fd);
- return ret;
+ return 0;
}

static int qib_ctxt_info(struct file *fp, struct qib_ctxt_info __user *uinfo)
--
2.7.4

2019-07-25 18:11:02

by Jason Gunthorpe

Subject: Re: [PATCH] infiniband: hw: qib: Unneeded variable ret

On Tue, Jul 16, 2019 at 10:59:25PM +0530, Hariprasad Kelam wrote:
> fix below issue reported by coccicheck
> drivers/infiniband/hw/qib/qib_file_ops.c:1792:5-8: Unneeded variable:
> "ret". Return "0" on line 1876
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
> ---
> drivers/infiniband/hw/qib/qib_file_ops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-next, thanks

Jason