2019-07-26 09:23:23

by Guido Günther

Subject: [PATCH 2/3] drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable()

This makes it symmetric with the panel init happening in enable().

Signed-off-by: Guido Günther <[email protected]>
---
drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
index c6b4bfd79fde..cc89831e30a6 100644
--- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
+++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
@@ -158,19 +158,23 @@ static int jh057n_enable(struct drm_panel *panel)
static int jh057n_disable(struct drm_panel *panel)
{
struct jh057n *ctx = panel_to_jh057n(panel);
+ struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
+ int ret;
+
+ ret = backlight_disable(ctx->backlight);
+ if (ret < 0)
+ return ret;

- return backlight_disable(ctx->backlight);
+ return mipi_dsi_dcs_set_display_off(dsi);
}

static int jh057n_unprepare(struct drm_panel *panel)
{
struct jh057n *ctx = panel_to_jh057n(panel);
- struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);

if (!ctx->prepared)
return 0;

- mipi_dsi_dcs_set_display_off(dsi);
regulator_disable(ctx->iovcc);
regulator_disable(ctx->vcc);
ctx->prepared = false;
--
2.20.1

2019-07-26 10:17:08

by Sam Ravnborg

Subject: Re: [PATCH 2/3] drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable()

Hi Guido.

On Fri, Jul 26, 2019 at 11:21:42AM +0200, Guido G?nther wrote:
> This makes it symmetric with the panel init happening in enable().
>
> Signed-off-by: Guido G?nther <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> index c6b4bfd79fde..cc89831e30a6 100644
> --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> @@ -158,19 +158,23 @@ static int jh057n_enable(struct drm_panel *panel)
> static int jh057n_disable(struct drm_panel *panel)
> {
> struct jh057n *ctx = panel_to_jh057n(panel);
> + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
> + int ret;
> +
> + ret = backlight_disable(ctx->backlight);
> + if (ret < 0)
> + return ret;
We most likely do not want to skip mipi_dsi_dcs_set_display_off()
just because we fail to disable backlight.
Most other panels disable backlight without a check for the return
value.

Sam