2019-07-25 21:29:17

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the sound-asoc tree

Hi all,

In commit

9fcf9139a2fd ("ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s master mode")

Fixes tag

Fixes: 2302be4126f52 ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

has these problem(s):

- Target SHA1 does not exist

Did you mean

Fixes: ca3d9433349e ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-07-26 06:07:22

by Peter Ujfalusi

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the sound-asoc tree

Stephen,

On 26/07/2019 0.27, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 9fcf9139a2fd ("ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s master mode")
>
> Fixes tag
>
> Fixes: 2302be4126f52 ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: ca3d9433349e ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

Indeed this is the correct SHA1, looks like the 2302be4126f52 is on TI's
4.19-LTS branch and it got into the commit message because I have
validated first on that before moving on to linux-next.

Mark: can you either drop the patch and I'll send a new one with fixed
SHA1 or can you fix the commit message in place?

Sorry.

- P?ter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2019-07-26 12:51:30

by Mark Brown

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the sound-asoc tree

On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote:

> Mark: can you either drop the patch and I'll send a new one with fixed
> SHA1 or can you fix the commit message in place?

Both of which involve rebasing :( Against my better judgement I
rebased.

Attachments:
(No filename) (271.00 B)
 signature.asc (499.00 B)
 Download all attachments

2019-07-29 05:58:23

by Peter Ujfalusi

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the sound-asoc tree

Mark,

On 26/07/2019 15.11, Mark Brown wrote:
> On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote:
>
>> Mark: can you either drop the patch and I'll send a new one with fixed
>> SHA1 or can you fix the commit message in place?
>
> Both of which involve rebasing :( Against my better judgement I
> rebased.

thank you and sorry again...

- P?ter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki