2019-07-27 18:27:32

by Minwoo Im

[permalink] [raw]
Subject: [PATCH 2/2] lightnvm: print error when target is not found

If userspace requests target to be removed, nvm_remove_tgt() will
iterate the nvm_devices to find out the given target, but if not
found, then it should print out the error.

Cc: Matias Bjørling <[email protected]>
Cc: Javier González <[email protected]>
Signed-off-by: Minwoo Im <[email protected]>
---
drivers/lightnvm/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index 4c7b48f72e80..4c89a2420a51 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -494,8 +494,11 @@ static int nvm_remove_tgt(struct nvm_ioctl_remove *remove)
}
up_read(&nvm_lock);

- if (!t)
+ if (!t) {
+ pr_err("failed to remove target %s not found\n",
+ remove->tgtname);
return 1;
+ }

__nvm_remove_target(t, true);
kref_put(&dev->ref, nvm_free);
--
2.17.1