2019-07-29 09:17:21

by Yue Haibing

Subject: [PATCH] drm/bridge: tc358764: Fix build error

If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m,
building fails:

drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'
drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x240): undefined reference to `drm_helper_probe_single_connector_modes'
drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x268): undefined reference to `drm_atomic_helper_connector_duplicate_state'
drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state'

Like TC358767, select DRM_KMS_HELPER to fix this, and
change to select DRM_PANEL to avoid recursive dependency.

Reported-by: Hulk Robot <[email protected]>
Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/bridge/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index a6eec90..323f72d 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -116,9 +116,10 @@ config DRM_THINE_THC63LVD1024

config DRM_TOSHIBA_TC358764
tristate "TC358764 DSI/LVDS bridge"
- depends on DRM && DRM_PANEL
depends on OF
select DRM_MIPI_DSI
+ select DRM_KMS_HELPER
+ select DRM_PANEL
help
Toshiba TC358764 DSI/LVDS bridge driver.

--
2.7.4

2019-07-30 04:39:57

by Laurent Pinchart

Subject: Re: [PATCH] drm/bridge: tc358764: Fix build error

Hi Yue,

Thank you for the patch.

On Mon, Jul 29, 2019 at 05:05:20PM +0800, YueHaibing wrote:
> If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m,
> building fails:
>
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x240): undefined reference to `drm_helper_probe_single_connector_modes'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x268): undefined reference to `drm_atomic_helper_connector_duplicate_state'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state'
>
> Like TC358767, select DRM_KMS_HELPER to fix this, and
> change to select DRM_PANEL to avoid recursive dependency.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index a6eec90..323f72d 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -116,9 +116,10 @@ config DRM_THINE_THC63LVD1024
>
> config DRM_TOSHIBA_TC358764
> tristate "TC358764 DSI/LVDS bridge"
> - depends on DRM && DRM_PANEL
> depends on OF
> select DRM_MIPI_DSI
> + select DRM_KMS_HELPER
> + select DRM_PANEL
> help
> Toshiba TC358764 DSI/LVDS bridge driver.
>

--
Regards,

Laurent Pinchart

2019-07-30 12:33:21

by Neil Armstrong

Subject: Re: [PATCH] drm/bridge: tc358764: Fix build error

On 29/07/2019 11:05, YueHaibing wrote:
> If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m,
> building fails:
>
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x240): undefined reference to `drm_helper_probe_single_connector_modes'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x268): undefined reference to `drm_atomic_helper_connector_duplicate_state'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state'
>
> Like TC358767, select DRM_KMS_HELPER to fix this, and
> change to select DRM_PANEL to avoid recursive dependency.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpu/drm/bridge/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index a6eec90..323f72d 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -116,9 +116,10 @@ config DRM_THINE_THC63LVD1024
>
> config DRM_TOSHIBA_TC358764
> tristate "TC358764 DSI/LVDS bridge"
> - depends on DRM && DRM_PANEL
> depends on OF
> select DRM_MIPI_DSI
> + select DRM_KMS_HELPER
> + select DRM_PANEL
> help
> Toshiba TC358764 DSI/LVDS bridge driver.
>
>

Reviewed-by: Neil Armstrong <[email protected]>

2019-07-30 12:50:15

by Neil Armstrong

Subject: Re: [PATCH] drm/bridge: tc358764: Fix build error

On 30/07/2019 14:32, Neil Armstrong wrote:
> On 29/07/2019 11:05, YueHaibing wrote:
>> If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m,
>> building fails:
>>
>> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'
>> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x240): undefined reference to `drm_helper_probe_single_connector_modes'
>> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x268): undefined reference to `drm_atomic_helper_connector_duplicate_state'
>> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state'
>>
>> Like TC358767, select DRM_KMS_HELPER to fix this, and
>> change to select DRM_PANEL to avoid recursive dependency.
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
>> Signed-off-by: YueHaibing <[email protected]>
>> ---
>> drivers/gpu/drm/bridge/Kconfig | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>> index a6eec90..323f72d 100644
>> --- a/drivers/gpu/drm/bridge/Kconfig
>> +++ b/drivers/gpu/drm/bridge/Kconfig
>> @@ -116,9 +116,10 @@ config DRM_THINE_THC63LVD1024
>>
>> config DRM_TOSHIBA_TC358764
>> tristate "TC358764 DSI/LVDS bridge"
>> - depends on DRM && DRM_PANEL
>> depends on OF
>> select DRM_MIPI_DSI
>> + select DRM_KMS_HELPER
>> + select DRM_PANEL
>> help
>> Toshiba TC358764 DSI/LVDS bridge driver.
>>
>>
>
> Reviewed-by: Neil Armstrong <[email protected]>
>

Applying to drm-misc-fixes

Thanks,
Neil