2019-07-30 15:42:29

by Hubert Feurstein

Subject: [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value

Using the define here makes the code more expressive.

Signed-off-by: Hubert Feurstein <[email protected]>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 58e298cc90e0..85638b868d8e 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -430,7 +430,7 @@ int mv88e6xxx_port_setup_mac(struct mv88e6xxx_chip *chip, int port, int link,
return 0;

/* Port's MAC control must not be changed unless the link is down */
- err = chip->info->ops->port_set_link(chip, port, 0);
+ err = chip->info->ops->port_set_link(chip, port, LINK_FORCED_DOWN);
if (err)
return err;

--
2.22.0

2019-07-30 16:33:42

by Andrew Lunn

Subject: Re: [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value

On Tue, Jul 30, 2019 at 12:11:42PM +0200, Hubert Feurstein wrote:
> Using the define here makes the code more expressive.
>
> Signed-off-by: Hubert Feurstein <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2019-07-30 18:06:52

by David Miller

Subject: Re: [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value

From: Hubert Feurstein <[email protected]>
Date: Tue, 30 Jul 2019 12:11:42 +0200

> Using the define here makes the code more expressive.
>
> Signed-off-by: Hubert Feurstein <[email protected]>

Applied, thank you.