2019-08-01 10:38:57

by Anson Huang

Subject: [PATCH] gpio: mxc: Use devm_clk_get_optional instead of devm_clk_get

From: Anson Huang <[email protected]>

i.MX SoC's GPIO clock is optional, so it is better to use
devm_clk_get_optional instead of devm_clk_get.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/gpio/gpio-mxc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index b281358..7907a87 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -435,12 +435,9 @@ static int mxc_gpio_probe(struct platform_device *pdev)
return port->irq;

/* the controller clock is optional */
- port->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(port->clk)) {
- if (PTR_ERR(port->clk) == -EPROBE_DEFER)
- return -EPROBE_DEFER;
- port->clk = NULL;
- }
+ port->clk = devm_clk_get_optional(&pdev->dev, NULL);
+ if (IS_ERR(port->clk))
+ return PTR_ERR(port->clk);

err = clk_prepare_enable(port->clk);
if (err) {
--
2.7.4

2019-08-02 12:27:41

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: mxc: Use devm_clk_get_optional instead of devm_clk_get

czw., 1 sie 2019 o 10:54 <[email protected]> napisał(a):
>
> From: Anson Huang <[email protected]>
>
> i.MX SoC's GPIO clock is optional, so it is better to use
> devm_clk_get_optional instead of devm_clk_get.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> drivers/gpio/gpio-mxc.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index b281358..7907a87 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -435,12 +435,9 @@ static int mxc_gpio_probe(struct platform_device *pdev)
> return port->irq;
>
> /* the controller clock is optional */
> - port->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(port->clk)) {
> - if (PTR_ERR(port->clk) == -EPROBE_DEFER)
> - return -EPROBE_DEFER;
> - port->clk = NULL;
> - }
> + port->clk = devm_clk_get_optional(&pdev->dev, NULL);
> + if (IS_ERR(port->clk))
> + return PTR_ERR(port->clk);
>
> err = clk_prepare_enable(port->clk);
> if (err) {
> --
> 2.7.4
>

Patch applied, thanks!

Bart