2019-08-01 17:37:21

by Joel Savitz

[permalink] [raw]
Subject: [PATCH] mm: fix typo in comment

Fix spelling of successful (currently spelled successfull in kernel
source)

Signed-off-by: Joel Savitz <[email protected]>
---
include/linux/compaction.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/compaction.h b/include/linux/compaction.h
index 9569e7c786d3..4122df65eb44 100644
--- a/include/linux/compaction.h
+++ b/include/linux/compaction.h
@@ -38,12 +38,12 @@ enum compact_result {
COMPACT_CONTINUE,

/*
- * The full zone was compacted scanned but wasn't successfull to compact
+ * The full zone was compacted scanned but wasn't successful to compact
* suitable pages.
*/
COMPACT_COMPLETE,
/*
- * direct compaction has scanned part of the zone but wasn't successfull
+ * direct compaction has scanned part of the zone but wasn't successful
* to compact suitable pages.
*/
COMPACT_PARTIAL_SKIPPED,
--
2.18.1


2019-08-01 21:41:16

by Matthew Wilcox

[permalink] [raw]
Subject: Re: [PATCH] mm: fix typo in comment

On Thu, Aug 01, 2019 at 11:47:34AM -0400, Joel Savitz wrote:
> Fix spelling of successful (currently spelled successfull in kernel
> source)

If you're going to bother fixing the spelling, may as well fix the grammar
at the same time.

> /*
> - * The full zone was compacted scanned but wasn't successfull to compact
> + * The full zone was compacted scanned but wasn't successful to compact
> * suitable pages.
> */

... actually, I don't know what is meant here. Could it mean:

/*
* The full zone was scanned for compaction, but didn't produce
* suitable pages.
*/

> /*
> - * direct compaction has scanned part of the zone but wasn't successfull
> + * direct compaction has scanned part of the zone but wasn't successful
> * to compact suitable pages.

* Zone compaction had to stop before scanning the full zone, and
* no suitable pages were produced.