2019-08-07 10:36:04

by Julien Grall

Subject: [PATCH] arm64/ptrace: Fix typoes in sve_set() comment

The ptrace trace SVE flags are prefixed with SVE_PT_*. Update the
comment accordingly.

Signed-off-by: Julien Grall <[email protected]>
---
arch/arm64/kernel/ptrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 17525da8d5c8..0de3eae09d36 100644
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -870,7 +870,7 @@ static int sve_set(struct task_struct *target,
goto out;

/*
- * Apart from PT_SVE_REGS_MASK, all PT_SVE_* flags are consumed by
+ * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by
* sve_set_vector_length(), which will also validate them for us:
*/
ret = sve_set_vector_length(target, header.vl,
--
2.11.0

2019-08-07 10:52:07

by Dave Martin

Subject: Re: [PATCH] arm64/ptrace: Fix typoes in sve_set() comment

On Wed, Aug 07, 2019 at 11:34:45AM +0100, Julien Grall wrote:
> The ptrace trace SVE flags are prefixed with SVE_PT_*. Update the
> comment accordingly.
>
> Signed-off-by: Julien Grall <[email protected]>
> ---
> arch/arm64/kernel/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
> index 17525da8d5c8..0de3eae09d36 100644
> --- a/arch/arm64/kernel/ptrace.c
> +++ b/arch/arm64/kernel/ptrace.c
> @@ -870,7 +870,7 @@ static int sve_set(struct task_struct *target,
> goto out;
>
> /*
> - * Apart from PT_SVE_REGS_MASK, all PT_SVE_* flags are consumed by
> + * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by
> * sve_set_vector_length(), which will also validate them for us:
> */

Thanks for spotting that.

Reviewed-by: Dave Martin <[email protected]>

Cheers
---Dave