2019-07-31 08:57:02

by Ding Xiang

Subject: [PATCH] myri10ge: remove unneeded variable

"error" is unneeded,just return 0

Signed-off-by: Ding Xiang <[email protected]>
---
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index d8b7fba..a4165e1 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -3037,7 +3037,6 @@ static int myri10ge_set_mac_address(struct net_device *dev, void *addr)
static int myri10ge_change_mtu(struct net_device *dev, int new_mtu)
{
struct myri10ge_priv *mgp = netdev_priv(dev);
- int error = 0;

netdev_info(dev, "changing mtu from %d to %d\n", dev->mtu, new_mtu);
if (mgp->running) {
@@ -3049,7 +3048,7 @@ static int myri10ge_change_mtu(struct net_device *dev, int new_mtu)
} else
dev->mtu = new_mtu;

- return error;
+ return 0;
}

/*
--
1.9.1

2019-07-31 15:46:36

by David Miller

Subject: Re: [PATCH] myri10ge: remove unneeded variable

From: Ding Xiang <[email protected]>
Date: Wed, 31 Jul 2019 16:53:46 +0800

> "error" is unneeded,just return 0
>
> Signed-off-by: Ding Xiang <[email protected]>

Applied to net-next.

2019-08-08 05:44:05

by Jesse Brandeburg

Subject: Re: [PATCH] myri10ge: remove unneeded variable

On Wed, 31 Jul 2019 16:53:46 +0800
Ding Xiang <[email protected]> wrote:

> "error" is unneeded,just return 0
>
> Signed-off-by: Ding Xiang <[email protected]>

Reviewed-by: Jesse Brandeburg <[email protected]>