2019-08-09 16:28:52

by Suman Anna

Subject: [PATCH 0/2] Minor cleanups/improvements in rpmsg-client-sample

Hi Bjorn,

The following are minor cleanup/improvement patches to the rpmsg_client_sample.
The first patch is new, and the second patch is a repost. Appreciate it if you
can pick these up for 5.4 merge window.

regards
Suman

Suman Anna (2):
samples/rpmsg: Replace print_hex_dump() with print_hex_dump_debug()
samples/rpmsg: Introduce a module parameter for message count

samples/rpmsg/rpmsg_client_sample.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

--
2.22.0

2019-08-09 16:29:39

by Suman Anna

Subject: [PATCH 1/2] samples/rpmsg: Replace print_hex_dump() with print_hex_dump_debug()

Replace the raw print_hex_dump() call in the rpmsg_sample_cb() function
with the equivalent print_hex_dump_debug() better suited for dynamic
debug. This switch allows flexibility of controlling this trace through
dynamic debug when enabled.

Signed-off-by: Suman Anna <[email protected]>
---
samples/rpmsg/rpmsg_client_sample.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_client_sample.c
index 2a0695573b47..b9a99e621a5c 100644
--- a/samples/rpmsg/rpmsg_client_sample.c
+++ b/samples/rpmsg/rpmsg_client_sample.c
@@ -29,8 +29,8 @@ static int rpmsg_sample_cb(struct rpmsg_device *rpdev, void *data, int len,
dev_info(&rpdev->dev, "incoming msg %d (src: 0x%x)\n",
++idata->rx_count, src);

- print_hex_dump(KERN_DEBUG, __func__, DUMP_PREFIX_NONE, 16, 1,
- data, len, true);
+ print_hex_dump_debug(__func__, DUMP_PREFIX_NONE, 16, 1, data, len,
+ true);

/* samples should not live forever */
if (idata->rx_count >= MSG_LIMIT) {
--
2.22.0