2019-08-12 10:14:15

by Wen He

[permalink] [raw]
Subject: [v1 2/3] dt/bindings: clk: Add DT bindings for LS1028A Display output interface

Add DT bindings documentmation for the Clock of the LS1028A Display
output interface.

Signed-off-by: Wen He <[email protected]>
---
.../devicetree/bindings/clock/fsl,plldig.txt | 26 +++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/fsl,plldig.txt

diff --git a/Documentation/devicetree/bindings/clock/fsl,plldig.txt b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
new file mode 100644
index 000000000000..29c5a6117809
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
@@ -0,0 +1,26 @@
+NXP QorIQ Layerscape LS1028A Display output interface Clock
+===========================================================
+
+Required properties:
+ - compatible: shall contain "fsl,ls1028a-plldig"
+ - reg: Physical base address and size of the block registers
+ - #clock-cells: shall contain 1.
+ - clocks: a phandle + clock-specifier pairs, here should be
+ specify the reference clock of the system
+
+
+Example:
+
+/ {
+ ...
+
+ dpclk: clock-controller@f1f0000 {
+ compatible = "fsl,ls1028a-plldig";
+ reg = <0x0 0xf1f0000 0x0 0xffff>;
+ #clock-cells = <1>;
+ clocks = <&osc_27m>;
+ };
+
+ ...
+};
+
--
2.17.1


2019-08-13 19:01:32

by Stephen Boyd

[permalink] [raw]
Subject: Re: [v1 2/3] dt/bindings: clk: Add DT bindings for LS1028A Display output interface

Quoting Wen He (2019-08-12 03:02:16)
> diff --git a/Documentation/devicetree/bindings/clock/fsl,plldig.txt b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> new file mode 100644
> index 000000000000..29c5a6117809
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> @@ -0,0 +1,26 @@
> +NXP QorIQ Layerscape LS1028A Display output interface Clock
> +===========================================================

Can you convert this to YAML?

> +
> +Required properties:
> + - compatible: shall contain "fsl,ls1028a-plldig"
> + - reg: Physical base address and size of the block registers
> + - #clock-cells: shall contain 1.

As I said in the previous patch, this should probably be 0. Also, please
order this before the driver in the patch series and thread your
messages please. If you use git-send-email this is done for you pretty
easily.

> + - clocks: a phandle + clock-specifier pairs, here should be
> + specify the reference clock of the system
> +
> +

2019-08-14 09:51:41

by Wen He

[permalink] [raw]
Subject: RE: [EXT] Re: [v1 2/3] dt/bindings: clk: Add DT bindings for LS1028A Display output interface



> -----Original Message-----
> From: Stephen Boyd <[email protected]>
> Sent: 2019年8月14日 2:30
> To: Mark Rutland <[email protected]>; Michael Turquette
> <[email protected]>; Rob Herring <[email protected]>; Shawn Guo
> <[email protected]>; Wen He <[email protected]>;
> [email protected]; [email protected];
> [email protected]
> Cc: Leo Li <[email protected]>; [email protected]; Wen He
> <[email protected]>
> Subject: [EXT] Re: [v1 2/3] dt/bindings: clk: Add DT bindings for LS1028A
> Display output interface
>
> Caution: EXT Email
>
> Quoting Wen He (2019-08-12 03:02:16)
> > diff --git a/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> > b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> > new file mode 100644
> > index 000000000000..29c5a6117809
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> > @@ -0,0 +1,26 @@
> > +NXP QorIQ Layerscape LS1028A Display output interface Clock
> > +===========================================================
>
> Can you convert this to YAML?

Sure, no problem.

>
> > +
> > +Required properties:
> > + - compatible: shall contain "fsl,ls1028a-plldig"
> > + - reg: Physical base address and size of the block registers
> > + - #clock-cells: shall contain 1.
>
> As I said in the previous patch, this should probably be 0. Also, please order
> this before the driver in the patch series and thread your messages please. If
> you use git-send-email this is done for you pretty easily.

Understand, Will prepare and send next version patch.

Best Regards,
Wen

>
> > + - clocks: a phandle + clock-specifier pairs, here should be
> > + specify the reference clock of the system
> > +
> > +